CLI Changes Sub-PR: Configuration Subcommand #593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
This was referenced Aug 4, 2023
Merged
ErinvanderVeen
requested changes
Aug 14, 2023
Xophmeister
force-pushed
the
chris/cli-changes
branch
from
8c23752
to
fb8fc03
Compare
As there are several potential sources of configuration, the collation mode is relevant whether a invocation-specific configuration file is specified, or not. This has the cheery consequence of sidestepping the issue described in clap-rs/clap#5020.
Xophmeister
force-pushed
the
chris/new-cli/config
branch
from
c77cea6
to
2432177
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This forms a part of PR #583 and must not be merged into
mainalone. It is only the implementation of isolated functionality -- and thus not expected to necessarily pass the CI checks -- to split up the work into logical chunks.NOTE Depends on #591.