Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds an explicit devShell to our flake #600

Merged
merged 3 commits into from
Aug 24, 2023
Merged

Adds an explicit devShell to our flake #600

merged 3 commits into from
Aug 24, 2023

Conversation

ErinvanderVeen
Copy link
Collaborator

Also reworks the way we call default.nix a little bit.

Erin van der Veen added 2 commits August 22, 2023 16:13
Move creation of rustPkgs to flake
23f4621 
Also clean up some of the arguments passed to default.nix
Create devShell with clippy, flamegraph, etc
414e519
@ErinvanderVeen ErinvanderVeen self-assigned this Aug 22, 2023
Xophmeister
Xophmeister approved these changes Aug 23, 2023
View reviewed changes
Copy link
Member

@Xophmeister Xophmeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I should caveat this approval with, "I am not a Nix person" 😅 This looks coherent, but I don't fully understand the consequences.

shell.nix Show resolved Hide resolved
@ErinvanderVeen ErinvanderVeen merged commit 577fe94 into main Aug 24, 2023
4 checks passed
@ErinvanderVeen ErinvanderVeen deleted the erin/flake-devshell branch August 24, 2023 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xophmeister Xophmeister Xophmeister approved these changes

Assignees

@ErinvanderVeen ErinvanderVeen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ErinvanderVeen @Xophmeister @toastal