Add createdBy field on custom object creation #6529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR adds a createdBy field to custom objects and addresses a bug related to custom fields named 'data' in mutations.
packages/twenty-server/src/engine/api/graphql/workspace-query-builder/factories/create-many-query.factory.ts: Fixed bug withargs.datahandling to avoid conflicts with 'data' custom fields.packages/twenty-server/src/engine/metadata-modules/object-metadata/object-metadata.service.ts: AddedcreatedByfield and movednameandpositionfields to default columns.packages/twenty-server/src/engine/workspace-manager/workspace-migration-runner/utils/custom-table-default-column.util.ts: Added new default columns includingcreatedBySourceandcreatedByWorkspaceMemberId.packages/twenty-server/src/engine/workspace-manager/workspace-migration-runner/workspace-migration-runner.service.ts: UpdatedcreateTablemethod to dynamically generate default columns based on table name.packages/twenty-server/src/engine/api/graphql/workspace-query-builder/factories/update-one-query.factory.ts: Fixed bug withargs.datahandling in update mutations.
8 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
Weiko
reviewed
Aug 4, 2024
| @@ -265,6 +265,20 @@ export class ObjectMetadataService extends TypeOrmQueryService<ObjectMetadataEnt | |||
| workspaceId: objectMetadataInput.workspaceId, | |||
| defaultValue: 'now', | |||
| }, | |||
| { | |||
| { | ||
| name: 'createdBySource', | ||
| type: 'enum', | ||
| enumName: `${tableName}_createdBySource_enum`, |
There was a problem hiding this comment.
I'm always confused with that, are we really using camelcase for enum names? @charlesBochet (including the tableName that will be in camelCase as well)
There was a problem hiding this comment.
yes, everything is camelCase and values should be UPPER_CASE
charlesBochet
added a commit
that referenced
this pull request
Aug 4, 2024
…ed (#6531) In this PR: - take feedbacks from: #6530 / #6529 / #6526 / #6512 - refactor onboarding uservars to be absent when the user is fully onboarded: isStepComplete ==> isStepIncomplete - introduce a new workspace.activationStatus: CREATION_ONGOING I'm retesting the whole flow: - with/without BILLING - sign in with/without SSO - sign up with/without SSO - another workspaceMembers join the team - subscriptionCanceled - access to billingPortal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, I'm:
nameandpositiondefault column to the set of columns automatically creation on object creation