Refactor onboarding user vars to be absent when user is fully onboarded #6531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Refactored onboarding user variables to be absent when the user is fully onboarded and introduced a new workspace activation status.
/packages/twenty-server/src/engine/core-modules/onboarding/onboarding.service.ts: RefactoredisStepCompletetoisStepIncompleteand simplified subscription checks usingBillingService./packages/twenty-server/src/database/commands/upgrade-version/0-23/0-23-backfill-new-onboarding-user-vars.ts: Simplified logic for fetching workspaces using object spread syntax./packages/twenty-server/src/engine/core-modules/billing/services/billing.service.ts: IntroducedBillingServicefor managing billing-related functionality./packages/twenty-server/src/engine/core-modules/billing/services/billing-subscription.service.ts: Enhanced error handling by renaming methods to enforce stricter validation./packages/twenty-server/src/engine/core-modules/billing/stripe/stripe.service.ts: RefactoredformatProductPricesmethod for improved readability and efficiency.
7 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings
Comment on lines
47
to
48
| !isDefined(currentBillingSubscription) || | ||
| currentBillingSubscription?.status === SubscriptionStatus.Incomplete |
There was a problem hiding this comment.
logic: The logic here seems inverted. Shouldn't it return true if currentBillingSubscription is defined and its status is not Incomplete?
Suggested change
| !isDefined(currentBillingSubscription) || | |
| currentBillingSubscription?.status === SubscriptionStatus.Incomplete | |
| return ( | |
| isDefined(currentBillingSubscription) && | |
| currentBillingSubscription.status !== SubscriptionStatus.Incomplete | |
| ); |
Weiko
approved these changes
Aug 4, 2024
charlesBochet
commented
Aug 4, 2024
| @@ -24,11 +24,20 @@ export const PrefetchRunQueriesEffect = () => { | |||
| prefetchKey: PrefetchKey.AllFavorites, | |||
| }); | |||
|
|
|||
| const { objectMetadataItems } = useObjectMetadataItems(); | |||
There was a problem hiding this comment.
refactor PrefetchQueries to make sure that they are leveraging operationSignatures
martmull
reviewed
Aug 4, 2024
| }); | ||
| } | ||
|
|
||
| async toggleOnboardingCreateProfileCompletion({ | ||
| async setOnboardingCreateProfileCompletion({ |
There was a problem hiding this comment.
setOnboardingCreateProfilePending
| value: true, | ||
| }); | ||
|
|
||
| await this.onboardingService.setOnboardingCreateProfileCompletion({ |
There was a problem hiding this comment.
should not be called if firstName!=='' && lastName!==''
| value: true, | ||
| }); | ||
|
|
||
| await this.onboardingService.setOnboardingCreateProfileCompletion({ |
There was a problem hiding this comment.
should not be called if firstName!=='' && lastName!==''
FelixMalfait
pushed a commit
that referenced
this pull request
Aug 7, 2024
see comments in #6531 (review) - rename method - add check before setting create profile pending user var
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR:
I'm retesting the whole flow: