synchronize sourceContext #4050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabpot
requested changes
Apr 24, 2024
fabpot
force-pushed
the
synchronize-sourcecontext
branch
from
a9dc261
to
350670a
Compare
|
Thank you @Lumaraf. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have some debugging extensions that need the template name from various nodes in a
NodeVisitor. Currently this is guaranteed for the nodes created from parsing the template. This ensures that theSourceContextis also set for nodes created byNodeVisitorsmodifying the node tree.I am not sure if it is a good idea to always set the
SourceContexton a child node or if this should only set it if it is not set.