Optimized TextNodes have no SourceContext #4046
Conversation
| if (Node::class === get_class($node)) { | ||
| return new TextNode($text, $node->getTemplateLine()); | ||
| $textNode = new TextNode($text, $line); | ||
| $textNode->setSourceContext($sourceContext); |
There was a problem hiding this comment.
this will break if $sourceContext is null.
But maybe the right fix would be for \Twig\Node\Node::setNode to set the source context in the new node in case we have a source context and the node being set does not have one. This would be consistent with the fact that setSourceContext also sets the node on all children at the time it is set.
this way, it would work for the nodes created by OptimizerNodeVisitor but would also solve the similar issue for any other custom node visitor
There was a problem hiding this comment.
Setting the SourceContext in setNode sounds like a great idea. That solves my current problem with missing SourceContexts after optimization and simplifies all of my current NodeVisitor use cases where i have to set the SourceContext everywhere i create new nodes.
I created a separate PR for that small change: #4050
| @@ -42,6 +42,7 @@ final class OptimizerNodeVisitor implements NodeVisitorInterface | |||
| { | |||
| public const OPTIMIZE_ALL = -1; | |||
| public const OPTIMIZE_NONE = 0; | |||
| public const OPTIMIZE_PRINT = 1; | |||
There was a problem hiding this comment.
making this optimization configurable would deserve a dedicated PR (as it deserve a changelog entry for such new feature)
There was a problem hiding this comment.
Makes sense, i extracted those changes into a separate PR #4051.
|
I think this one can be closed now, right? |
Fixes #4045