allow turning all optimizations off #4051
Conversation
| @@ -81,7 +82,9 @@ public function leaveNode(Node $node, Environment $env): ?Node | |||
| $node = $this->optimizeRawFilter($node); | |||
| } | |||
|
|
|||
| $node = $this->optimizePrintNode($node); | |||
| if (self::OPTIMIZE_PRINT === (self::OPTIMIZE_PRINT & $this->optimizers)) { | |||
There was a problem hiding this comment.
Why would we want to be able to disable this optimization. I didn't provide a way to disable it on purpose.
There was a problem hiding this comment.
I ran into problems with one of my own extension because of missing SourceContexts on nodes created by the PrintNode and TextNode optimizations. The obvious solution to me would be to turn off those or all optimizers, but setting the optimizers property on TwigEnvironment to 0/OptimizerNodeVisitor::OPTIMIZE_NONE still leaves the PrintNode optimization active.
There was a problem hiding this comment.
As we are fixing the source context, would you agree that there is not need to make this optimization configurable?
There was a problem hiding this comment.
The source context fix is sufficient to solve my current problems. I still think this should be fixed though as the optimizers option currently doesn't behave in the way it is described in the doc comment in
Lines 100 to 102 in 4a7de4a
0 does not disable all optimizations.
Currently setting the
TwigEnvironmentoptionoptimizersto 0 (OptimizerNodeVisitor::OPTIMIZE_NONE) does not turn of thePrintNodeoptimization.