Type-checking fixes #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically deployed with Now. Latest deployment for this branch: https://paste-git-type-check-fixes.twilio-dsys.now.sh |
SiTaggart
previously approved these changes
Jul 26, 2019
- Clean tsconfig file - Add type-check:watch command
TheSisb
force-pushed
the
type-check-fixes
branch
from
6e01adc
to
9dba403
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
type-checkcommand runs in that package's scopeyarn type-check:watchcommand for the website package. Because gatsby-typescript uses babel-typescript (which simply removes typings and compiles), the only type-checking we see is in our editors. It is helpful in some cases to have a separate watcher running during dev.