feat(core): a core bundle #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheSisb
added
Type: Enhancement
|
This pull request is being automatically deployed with ZEIT Now (learn more). 🔍 Inspect: https://zeit.co/twilio-dsys/paste/7c6ka3sb2 |
TheSisb
commented
Oct 15, 2019
| } | ||
|
|
||
| // Main | ||
| (async () => { |
There was a problem hiding this comment.
Reading this function explains the main procedure that happens right before a build is triggered on this package.
There was a problem hiding this comment.
Using private, version, and blacklisted seems like a good way to handle that filter. I like it.
richbachman
reviewed
Oct 15, 2019
|
The |
SiTaggart
approved these changes
Oct 22, 2019
richbachman
approved these changes
Oct 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a "Core bundle". This was added to make it easier to start using Paste by combining all of our packages into a single import.
The general approach I took to making this work was by using Lerna to fetch all the packages in our monorepo. I then filter some out and proceed to generate the
package.jsonandindex.tsxfiles.Open questions: