-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(popover): add state hook prop #1606
Conversation
🦋 Changeset detectedLatest commit: 5d4bfd7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✔️ Deploy Preview for paste-docs ready! 🔨 Explore the source changes: 5d4bfd7 🔍 Inspect the deploy log: https://app.netlify.com/sites/paste-docs/deploys/60e5da830575f50008b52aa3 😎 Browse the preview: https://deploy-preview-1606--paste-docs.netlify.app |
Size Change: +76 B (0%) Total Size: 599 kB
ℹ️ View Unchanged
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 5d4bfd7:
|
Test summaryRun details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
410e846
to
1552c7f
Compare
packages/paste-website/src/pages/components/disclosure/index.mdx
Outdated
Show resolved
Hide resolved
packages/paste-website/src/pages/components/disclosure/index.mdx
Outdated
Show resolved
Hide resolved
1552c7f
to
9ca6b8f
Compare
packages/paste-website/src/component-examples/DisclosureExamples.ts
Outdated
Show resolved
Hide resolved
9ca6b8f
to
9cbe5e9
Compare
packages/paste-core/components/popover/src/PopoverContainer.tsx
Outdated
Show resolved
Hide resolved
packages/paste-core/components/popover/__tests__/index.spec.tsx
Outdated
Show resolved
Hide resolved
9cbe5e9
to
328964c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Definitely good to include the links to the Reakit Docs in the state examples sections of our docs, helped me understand the hooks more clearly and know that I could customize more actions if I wanted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Outside that one question on refs, it looks good to me.
d3807f6
to
5d4bfd7
Compare
state
prop to Popover