fix(select): select background color #2242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 5d0f23c The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
Status: Do Not Merge
|
✔️ Deploy Preview for paste-theme-designer ready! 🔨 Explore the source changes: 5d0f23c 🔍 Inspect the deploy log: https://app.netlify.com/sites/paste-theme-designer/deploys/621934685c91aa00077406b5 😎 Browse the preview: https://deploy-preview-2242--paste-theme-designer.netlify.app |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 5d0f23c:
|
|
Size Change: +15 B (0%) Total Size: 466 kB
ℹ️ View Unchanged
|
|
✔️ Deploy Preview for paste-docs ready! 🔨 Explore the source changes: 843a2c5 🔍 Inspect the deploy log: https://app.netlify.com/sites/paste-docs/deploys/62182ad6f69b5c2e30bfc808 😎 Browse the preview: https://deploy-preview-2242--paste-docs.netlify.app |
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
SiTaggart
approved these changes
Feb 25, 2022
TheSisb
approved these changes
Feb 25, 2022
loreina
approved these changes
Feb 25, 2022
Closed
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when you use the Paste Select component in dark mode on firefox, the text is light grey on a white background. It appears that when you set the color on a select in FF, the browser takes out all the default styles for the dropdown and just makes it white.
For more context: https://codesandbox.io/s/firefox-select-bug-wk3x4d?file=/src/App.tsx
colorBackgroundcolorBackgroundInverse"inherit""inherit"as a valid backgroundColorSelect in light mode in Firefox:
Select in dark mode in Firefox:
Contributing to Twilio