chore: remove __console_patch prop
#2697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 198a805 The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
Status: Do Not Merge
github-actions
bot
added
Area: Components
✅ Deploy Preview for paste-theme-designer ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for paste-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 198a805:
|
|
Test summaryRun details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
|
Size Change: -273 B (0%) Total Size: 748 kB
ℹ️ View Unchanged
|
SiTaggart
previously approved these changes
Sep 28, 2022
TheSisb
previously approved these changes
Sep 28, 2022
| } | ||
|
|
||
| // eslint-disable-next-line @typescript-eslint/no-explicit-any | ||
| const getAnimationStates = (isConsole: boolean): any => ({ | ||
| const getAnimationStates = (): any => ({ |
There was a problem hiding this comment.
sugestion: this doesn't need to be a function anymore
There was a problem hiding this comment.
I refactored the function to be an object but I'm getting this ts error
There was a problem hiding this comment.
Ok let's leave it as a function
serifluous
previously approved these changes
Sep 28, 2022
ghost
previously approved these changes
Sep 29, 2022
nkrantz
dismissed stale reviews from ghost
, serifluous, TheSisb, and SiTaggart
via
198a805
nkrantz
force-pushed
the
remove-console-patch
branch
from
d3a763d
to
198a805
Compare
TheSisb
approved these changes
Sep 29, 2022
shleewhite
approved these changes
Sep 29, 2022
serifluous
approved these changes
Sep 29, 2022
nkrantz
added
🕵🏻♀️ Run website visual regression
Merged
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DSYS-3880
This removes the
__console_patchprop from the Modal component, Modal docs and Modal stories.