feat: create the chat composer component #2825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 99c26dd The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
Status: Do Not Merge
github-actions
bot
added
Area: Components
shleewhite
commented
Nov 14, 2022
shleewhite
commented
Nov 14, 2022
packages/paste-core/components/chat-composer/__tests__/index.spec.tsx
Outdated
Show resolved
Hide resolved
shleewhite
commented
Nov 14, 2022
✅ Deploy Preview for paste-theme-designer ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for paste-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
shleewhite
commented
Nov 14, 2022
shleewhite
commented
Nov 14, 2022
packages/paste-core/components/chat-composer/src/ChatComposer.tsx
Outdated
Show resolved
Hide resolved
shleewhite
commented
Nov 14, 2022
packages/paste-core/components/chat-log/stories/components/ChatAttachment.stories.tsx
Show resolved
Hide resolved
|
Test summaryRun details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 99c26dd:
|
|
Size Change: +487 B (0%) Total Size: 830 kB
ℹ️ View Unchanged
|
|
OPEN QUESTION: Do I need to add an entry to the upgrade guide? Its only adding a new component and core doesn't have a major version change. Update: asked in standup, will make a ticket to investigate this and we'll ignore this failure when the PR is ready to merge. |
nkrantz
reviewed
Nov 15, 2022
packages/paste-core/components/chat-composer/src/ChatComposer.tsx
Outdated
Show resolved
Hide resolved
shleewhite
force-pushed
the
feat/chat-composer
branch
from
0d71479
to
ba0d3df
Compare
gloriliale
reviewed
Nov 17, 2022
packages/paste-core/components/minimizable-dialog/src/MinimizableDialogContent.tsx
Show resolved
Hide resolved
shleewhite
force-pushed
the
feat/chat-composer
branch
from
a2ceaa0
to
a523b38
Compare
github-actions
bot
removed
the
Area: Infrastructure
TheSisb
reviewed
Nov 18, 2022
packages/paste-core/components/chat-composer/src/PlaceholderWrapper.tsx
Outdated
Show resolved
Hide resolved
gloriliale
previously approved these changes
Nov 18, 2022
There was a problem hiding this comment.
@shleewhite
Issue: I left a comment in Chromatic, but there's an issue with the long placeholder text, this might just be something with storybook though? Here's a screenshot of what I'm seeing at smaller screen sizes:
kelseycavitt
previously approved these changes
Nov 29, 2022
gloriliale
previously approved these changes
Nov 29, 2022
ghost
previously approved these changes
Nov 29, 2022
shleewhite
dismissed stale reviews from ghost
, gloriliale, and kelseycavitt
via
99e48cd
shleewhite
force-pushed
the
feat/chat-composer
branch
from
99e48cd
to
ad7a022
Compare
shleewhite
added
the
🕵🏻♀️ Run website visual regression
nkrantz
reviewed
Nov 29, 2022
.changeset/smooth-pumpkins-wonder.md
Outdated
Comment on lines
2
to
3
| '@twilio-paste/button': patch | ||
| '@twilio-paste/core': minor |
There was a problem hiding this comment.
question (non-blocking): why is this a patch for button and a minor for core?
There was a problem hiding this comment.
DANG - bad copy paste. just pushed a fix.
kelseycavitt
previously approved these changes
Nov 29, 2022
shleewhite
dismissed stale reviews from kelseycavitt and nkrantz
via
99c26dd
TheSisb
approved these changes
Nov 29, 2022
nkrantz
approved these changes
Nov 29, 2022
gloriliale
approved these changes
Nov 29, 2022
ghost
approved these changes
Nov 29, 2022
shleewhite
added
🚀 merge it!
and removed
Status: Do Not Merge
kelseycavitt
approved these changes
Nov 29, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new ChatComposer component and lexical library.
In this PR
I have a few open questions that can be seen as comments in the PR.
Contributing to Twilio