feat: add support for React 18 #2965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 4a408ae The changes in this PR will be included in the next version bump. This PR includes changesets to release 96 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
Status: Do Not Merge
github-actions
bot
added
Area: Components
✅ Deploy Preview for paste-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Passing run #5392 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
|||||||||||||||
|
Size Change: +4.13 kB (0%) Total Size: 902 kB
ℹ️ View Unchanged
|
✅ Deploy Preview for paste-theme-designer ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Niznikr
force-pushed
the
feat/react-18
branch
2 times, most recently
from
da061ae
to
6e9dc5f
Compare
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 4a408ae:
|
TheSisb
reviewed
Feb 9, 2023
.changeset/lucky-years-doubt.md
Outdated
| '@twilio-paste/toast': minor | ||
| '@twilio-paste/tooltip': minor | ||
| '@twilio-paste/truncate': minor | ||
| '@twilio-paste/core': minor |
There was a problem hiding this comment.
Let's make this a major for all
There was a problem hiding this comment.
OK, I won't bother amending my changeset. Let's bundle in a few majors together
gloriliale
previously approved these changes
Feb 9, 2023
SiTaggart
reviewed
Feb 9, 2023
| @@ -26,7 +26,7 @@ const Wrapper = styled.div( | |||
| }) | |||
| ); | |||
|
|
|||
| export const AllBadges: React.FC = () => ( | |||
| export const AllBadges = (): JSX.Element => ( | |||
There was a problem hiding this comment.
suggest (non-blocking): If you were going to the effort of swapping all these, you could swap them to
export const AllBadges:StoryFn = () => (
Which returns a JSX.Element
SiTaggart
reviewed
Feb 9, 2023
| headerSort.click(); | ||
| act(() => { | ||
| headerSort.click(); | ||
| }); |
There was a problem hiding this comment.
praise: Nice. Wonder if we're seeing some speed improvements on these tests now?
SiTaggart
reviewed
Feb 9, 2023
| @@ -102,7 +107,7 @@ const Select = React.forwardRef<HTMLSelectElement, SelectProps>( | |||
| size={multiple ? size : 0} | |||
| variant={variant} | |||
| > | |||
| {children} | |||
| {showOptions && children} | |||
There was a problem hiding this comment.
question: should this have it's own changeset? I know its for hydration, but if someone upgrades would it be useful to us or them to have a call out specifically in this components changelog mentioning this change?
There was a problem hiding this comment.
Yeah a changeset could be helpful for this!
SiTaggart
force-pushed
the
feat/react-18
branch
from
766ad8e
to
4a408ae
Compare
SiTaggart
approved these changes
Feb 22, 2023
SiTaggart
removed
the
Status: Do Not Merge
TheSisb
approved these changes
Feb 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@twilio-paste/uid-libraryto detect and use React'suseIdhook if available