Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(website): composable do-dont, add anchor examples #81

Merged
merged 26 commits into from
Sep 11, 2019
Merged

fix(website): composable do-dont, add anchor examples #81

merged 26 commits into from
Sep 11, 2019

Conversation

richbachman
Copy link
Contributor

@richbachman richbachman commented Sep 3, 2019 •
edited
Loading

  • Refactored do-dont component so its composable. This allows for more flexibility of the content
  • Added assets file-system
  • Added anchor page image and component do-donts
  • Added button page do-donts
  • Added AspectRatio core utility
  • Added AspectRatio story
  • Added AspectRatio test

Contributing to Twilio

All third-party contributors acknowledge that any contributions they provide will be made under the same open-source license that the open-source project is provided under.

  • I acknowledge that all my contributions will be made under the project's license.

@richbachman richbachman added Type: Documentation Improvements or additions to documentation Status: WIP This PR is still a work-in-progress. No need to review. Status: Pls CR This PR is ready for Code Reviews Area: Doc Site Related to the documentation website labels Sep 3, 2019
@vercel
Copy link

vercel bot commented Sep 3, 2019 •
edited
Loading

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://paste-git-refactor-do-dont.twilio-dsys.now.sh

@vercel vercel bot temporarily deployed to staging September 4, 2019 22:26 Inactive
@richbachman richbachman removed the Status: WIP This PR is still a work-in-progress. No need to review. label Sep 4, 2019
@vercel vercel bot requested a deployment to staging September 4, 2019 22:39 Abandoned
@vercel vercel bot requested a deployment to staging September 4, 2019 22:39 Abandoned
TheSisb
TheSisb approved these changes Sep 9, 2019
View reviewed changes
Copy link
Contributor

@TheSisb TheSisb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks legit, nice!

@vercel vercel bot temporarily deployed to staging September 11, 2019 18:45 Inactive
@richbachman richbachman merged commit a799f1b into master Sep 11, 2019
@richbachman richbachman deleted the refactor-do-dont branch September 11, 2019 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheSisb TheSisb TheSisb approved these changes

@SiTaggart SiTaggart SiTaggart approved these changes

Assignees
No one assigned
Labels
Area: Doc Site Related to the documentation website Status: Pls CR This PR is ready for Code Reviews Type: Documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@richbachman @SiTaggart @TheSisb