Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(website): composable do-dont, add anchor examples #81

Merged
merged 26 commits into from Sep 11, 2019

Conversation

@richbachman
Copy link
Collaborator

richbachman commented Sep 3, 2019

  • Refactored do-dont component so its composable. This allows for more flexibility of the content
  • Added assets file-system
  • Added anchor page image and component do-donts
  • Added button page do-donts
  • Added AspectRatio core utility
  • Added AspectRatio story
  • Added AspectRatio test

Contributing to Twilio

All third-party contributors acknowledge that any contributions they provide will be made under the same open-source license that the open-source project is provided under.

  • I acknowledge that all my contributions will be made under the project's license.
@now

This comment has been minimized.

Copy link

now bot commented Sep 3, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://paste-git-refactor-do-dont.twilio-dsys.now.sh

@now now bot had a problem deploying to staging Sep 4, 2019 Failure
@now now bot temporarily deployed to staging Sep 4, 2019 Inactive
@now now bot requested a deployment to staging Sep 4, 2019 Abandoned
@now now bot requested a deployment to staging Sep 4, 2019 Abandoned
@now now bot had a problem deploying to staging Sep 4, 2019 Failure
@now now bot had a problem deploying to staging Sep 4, 2019 Failure
@now now bot had a problem deploying to staging Sep 4, 2019 Failure
@TheSisb
TheSisb approved these changes Sep 9, 2019
Copy link
Collaborator

TheSisb left a comment

This looks legit, nice!

@now now bot temporarily deployed to staging Sep 11, 2019 Inactive
@richbachman richbachman merged commit a799f1b into master Sep 11, 2019
5 checks passed
5 checks passed
Semantic Pull Request ready to be squashed
Details
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: prettier Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
now canceled by subsequent deployment
Details
@richbachman richbachman deleted the refactor-do-dont branch Sep 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.