chore: remove auth from request.__str__() #887
Merged
+40
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manisha1997
approved these changes
Oct 9, 2025
|
sbansla
reviewed
Oct 13, 2025
| ' -d "FriendlyName=My New Account"\n' | ||
| ' -H "X-Custom-Header: Value"' | ||
| ) | ||
| self.assertEqual(expected, req.__str__()) |
There was a problem hiding this comment.
Add a check that Authorization is not expected. Although on a second thought this should also work.
sbansla
approved these changes
Oct 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
removing auth values from str() so that the credentials can be prevented from entering into logs
Checklist
If you have questions, please file a support ticket, or create a GitHub Issue in this repository.