Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

find_one() modified to return None instead of {} when nothing found #106

Merged
merged 1 commit into from
May 27, 2015

Conversation

IlyaSkriblovsky
Copy link
Contributor

This change relates only to find_one, find still returns empty list when nothing was found

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.22%) to 90.94% when pulling 29c701b on IlyaSkriblovsky:findone-none into 137b363 on twisted:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.22%) to 90.94% when pulling 29c701b on IlyaSkriblovsky:findone-none into 137b363 on twisted:master.

@IlyaSkriblovsky
Copy link
Contributor Author

Looks like we have some lines which have unstable coverage. Sometimes they are visited during some tests and sometimes not. I mean these: https://coveralls.io/builds/2651523/source?filename=txmongo%2Fprotocol.py#L322
They were occasionally visited during previous build but not visited now, so coverage is decreased a bit.

@psi29a
Copy link
Contributor

psi29a commented May 27, 2015

I've seen those as well, likely the way those versions for Twisted work.

psi29a added a commit that referenced this pull request May 27, 2015
find_one() modified to return None instead of {} when nothing found
@psi29a psi29a merged commit 8e9c8db into twisted:master May 27, 2015
@IlyaSkriblovsky IlyaSkriblovsky deleted the findone-none branch May 27, 2015 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants