raise NotMasterError to indicate to client that it is safe to retry, … #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -297,12 +297,11 @@ def _get_write_concern(self, safe=None, **wc_options): | |||
| # In this case safe=True must issue getLastError without args | |||
| # even if connection-level write concern was unacknowledged | |||
| return WriteConcern() | |||
| elif safe == False: | |||
| elif not safe: | |||
There was a problem hiding this comment.
may be just else here? and remove final return self.write_concern. It is unreachable with this elif not safe anyways
…cleanup, add explicit test for AutoReconnect no with raises in twisted versions below 15 less code is better
retry_delay sounds better
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…cleanup, add explicit test for AutoReconnect