add deadline option to any function that contains getprotocol or depe… #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| while True: | ||
| try: | ||
| yield conn.db.coll.find_one(timeout=2) | ||
| raise Exception("TimeoutExceeded not raised!") |
There was a problem hiding this comment.
it's more clean to use self.fail() here
|
Is this intended that |
|
I'm working through them, thanks for noticing! |
…nds on function that does add the error class update docs impliment timeout in addition to deadline, updated docs typo fixes remove unnecessary kwargs use a decorator remove deadline/timeout from params, do kwarg magic in timeout decorator, update our tests tidy up timeout wrapper faster tests and coverage, fix imports remove unnused code, we will get back to that in next PR
|
Did a rebase squash in prep for merge. |
psi29a
added a commit
that referenced
this pull request
Sep 25, 2015
add deadline option to any function that contains getprotocol or depe…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…nds on function that does
This also includes NotMasterError