Auth using authsource db #207
Conversation
There was a problem hiding this comment.
Could you please add a test for this new supported uri option? Although code change is pretty obvious, this unit test could help us not to loose this functionality in future. You can probably just clone test_AuthConnectionPoolUri test method in tests/test_auth.py and change it accordingly.
The record in docs/source/NEWS.rst would be appreciated too!
txmongo/connection.py
Outdated
| @@ -298,6 +298,10 @@ def __tcp_or_ssl_connect(self, host, port, factory, **kwargs): | |||
| return reactor.connectTCP(host, port, factory, **kwargs) | |||
|
|
|||
| @property | |||
| def auth_db(self): | |||
| return self.__uri['options'].get('authsource') or self.__uri['database'] | |||
There was a problem hiding this comment.
This property adds to the public API of Connection without obvious reason. Why do we need this as a public property? Or even if we need it, its name falsely hints that it will return Database object, not str. My thinking that there is no bold reason to make this public and it is better to make it local variable inside __init__.
There was a problem hiding this comment.
Yes, property reduntant. I will fix it.
txmongo/connection.py
Outdated
| @@ -271,8 +271,8 @@ def __init__(self, uri="mongodb://127.0.0.1:27017", pool_size=1, ssl_context_fac | |||
| for i in range(pool_size) | |||
| ] | |||
|
|
|||
| if self.__uri['database'] and self.__uri['username'] and self.__uri['password']: | |||
| self.authenticate(self.__uri['database'], self.__uri['username'], | |||
| if self.__uri['database'] and self.__uri['username'] and self.__uri['password']: | |||
There was a problem hiding this comment.
Sorry for tediousness, but could you please remove the trailing whitespace?
|
Thanks for your contribution! Could you please address a couple of comments above? |
harlov
force-pushed
the
AuthSource_ignored_on_connect
branch
from
5d22504
to
2ff44f0
Compare
|
Thank you! |
Use 'authsource' as auth database, if specify in uri, and orig database if not.
https://docs.mongodb.com/manual/reference/connection-string/#urioption.authSource