Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests that encode and decode protocol messages and compare results #92

Merged
merged 2 commits into from
May 14, 2015

Conversation

IlyaSkriblovsky
Copy link
Contributor

A bunch of tests that encode protocol messages into bytes and then decode them using txmongo.protocol.MongoDecoder and compare decoded object with original request object.

This might be considered as additional check for encoding code. Also this will add test coverage for MongoDecoder class.

@coveralls
Copy link

coveralls commented May 13, 2015

Coverage Status

Coverage increased (+4.6%) to 78.959% when pulling edcd07b on IlyaSkriblovsky:tests-for-protocol-encoding into e6dd79f on twisted:master.

@coveralls
Copy link

coveralls commented May 13, 2015

Coverage Status

Coverage increased (+4.6%) to 78.959% when pulling aa6eafe on IlyaSkriblovsky:tests-for-protocol-encoding into e6dd79f on twisted:master.

@IlyaSkriblovsky
Copy link
Contributor Author

Failing tests in Travis are not linked to this PR. They are failings with "reactor unclean" and "trying to cancel already cancelled event" that sporadically appear on various tests from time to time (there is possbile race condition somewhere).

@psi29a
Copy link
Contributor

psi29a commented May 14, 2015

I saw, I can restart the tests and they eventually are green.

It happens on py26,27,pypy in almost all twisted versions.... so it will be a problem to track down.
Nice coverage improvement btw! :)

psi29a added a commit that referenced this pull request May 14, 2015
Tests that encode and decode protocol messages and compare results
@psi29a psi29a merged commit 04c8f56 into twisted:master May 14, 2015
@psi29a
Copy link
Contributor

psi29a commented May 14, 2015

I just restarted the 'whole' build process to be sure, and all builds are green. It might have something to do with load on the build machines?

@IlyaSkriblovsky
Copy link
Contributor Author

I saw same strange fails on my own PC. But fail probability was higher when
I ran tests in VirtualBox, so the probability seems to be somehow linked to
machine performance.

I bet txmongo (or its unittests) doesn't wait correctly for all cleanups.
And on showers machines cleanup takes a bit longer and trial complains
about dirty reactor.

BTW, these fails are always (or may be almost always) appear on aggregate
and gridfs tests.

I want to look into this issue today or tomorrow evening.

@psi29a
Copy link
Contributor

psi29a commented May 14, 2015

Sure, i'm doing some additional coverage in the meantime.

@IlyaSkriblovsky IlyaSkriblovsky deleted the tests-for-protocol-encoding branch May 14, 2015 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants