-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests that encode and decode protocol messages and compare results #92
Tests that encode and decode protocol messages and compare results #92
Conversation
Failing tests in Travis are not linked to this PR. They are failings with "reactor unclean" and "trying to cancel already cancelled event" that sporadically appear on various tests from time to time (there is possbile race condition somewhere). |
I saw, I can restart the tests and they eventually are green. It happens on py26,27,pypy in almost all twisted versions.... so it will be a problem to track down. |
Tests that encode and decode protocol messages and compare results
I just restarted the 'whole' build process to be sure, and all builds are green. It might have something to do with load on the build machines? |
I saw same strange fails on my own PC. But fail probability was higher when I bet txmongo (or its unittests) doesn't wait correctly for all cleanups. BTW, these fails are always (or may be almost always) appear on aggregate I want to look into this issue today or tomorrow evening. |
Sure, i'm doing some additional coverage in the meantime. |
A bunch of tests that encode protocol messages into bytes and then decode them using
txmongo.protocol.MongoDecoder
and compare decoded object with original request object.This might be considered as additional check for encoding code. Also this will add test coverage for
MongoDecoder
class.