Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the constructor parameter of HttpClientException #400

Closed
wants to merge 1 commit into from

Conversation

wolfapple
Copy link
Contributor

@wolfapple wolfapple commented Mar 31, 2017

Problem
When using the HttpClient.executeJson method, if the status of the response differs from expectedStatus, an HttpClientException is returned. The status and contentString of the response are used when creating an HttpClientException, but the value of status is actually inaccessible.

Solution
Change the constructor parameter of HttpClientException.

@codecov-io
Copy link

Codecov Report

Merging #400 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #400   +/-   ##
========================================
  Coverage    94.34%   94.34%           
========================================
  Files          224      224           
  Lines         3288     3288           
  Branches       255      255           
========================================
  Hits          3102     3102           
  Misses         186      186

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c4de3fb...4f2c3c2. Read the comment docs.

@mosesn
Copy link
Contributor

mosesn commented Mar 31, 2017

LGTM, thanks for the PR!

@mosesn mosesn added the ship it label Mar 31, 2017
@yufangong
Copy link
Contributor

Thanks @wolfapple for your contribution, this change has been merged in ff9b136.

@yufangong yufangong closed this Apr 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

4 participants