inject-request-scope: Cross-build for Scala 2.13 #553
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #553 +/- ##
===========================================
+ Coverage 90.92% 90.94% +0.02%
===========================================
Files 269 269
Lines 4872 4872
Branches 304 303 -1
===========================================
+ Hits 4430 4431 +1
+ Misses 442 441 -1
Continue to review full report at Codecov.
|
Problem inject-request-scope is not cross-built for Scala 2.13. Solution Update inject-request-scope module to cross-build for Scala 2.13 using new SBT settings. Result inject-request-scope is cross-built for Scala 2.13.
chrisbenincasa
force-pushed
the
inject-request-scope-2.13
branch
from
64efb7e
to
11009a7
Compare
|
@chrisbenincasa I have to apologize, I lost attribution when merging this here: 1e8dbd1. Really sorry about that. Let me know if you would like me to attempt to fix this. |
|
No worries!
…On Fri, Oct 9, 2020 at 4:44 PM Christopher Coco ***@***.***> wrote:
@chrisbenincasa <https://github.com/chrisbenincasa> I have to apologize,
I lost attribution when merging this here: 1e8dbd1
<1e8dbd1>.
Really sorry about that. Let me know if you would like me to attempt to fix
this.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#553 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAMQRX4TQRDLH76NHX5T4LTSJ5YZRANCNFSM4RFANQVQ>
.
|
Thanks for the work here! Merged in 1e8dbd1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
inject-request-scope is not cross-built for Scala 2.13.
Solution
Update inject-request-scope module to cross-build for Scala 2.13 using new SBT
settings.
Result
inject-request-scope is cross-built for Scala 2.13.