Test coverage uses bash

[seppo0010]

pushd/popd are not available in sh

Oops, my bad here. I should have tested it. I cannot wait for Travis integration.

[seppo0010]

Is pushd/popd every necessary?

I think it is desirable that if something fails (like a test) it will leave the user in the same location they were.

[seppo0010]

bash makes sure that popd is called automatically if the script fails. set -e (and &&) bails when any command fails and prevents further commands from being executed. For example:

~/Desktop $ cat ./example.bash
#!/usr/bin/env bash

set -e
mkdir -p test
pushd test
rm -rf fake-directory
ls fake-directory
echo "not called"
popd test
~/Desktop $ ./example.bash
~/Desktop/test ~/Desktop
ls: fake-directory: No such file or directory
~/Desktop $ echo $?
1

Implementing this without pushd/popd and using pwd instead is possible, but it would require an overhead of checking the return status of each command 😨.

[seppo0010]

ping @thinkingfish

[kevyang]

lgtm, ship it (given you've tested in osx and gnu/linux)