This repository has been archived by the owner on Jan 20, 2022. It is now read-only.
refactored core-tests into separate sub-project #593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1,23 @@ | |||
| import com.twitter.summingbird.{ KeyedProducer, Producer } | |||
There was a problem hiding this comment.
This is missing new line at end of file, package statement at the top and the apache header
|
man it would be cool if our tests worked. |
|
@johnynek Come to me with those concerns - Q2 is already fully booked, but I'll take it into consideration for the Q3 roadmap. |
|
@sritchie too real, man. |
Closed
|
@MansurAshraf can we close this one now? |
|
@johnynek no I need this merged for internal refactoring we are doing. |
|
To give a little context I need |
|
Okay, yes. Got it. Let me review. |
ianoc
added a commit
that referenced
this pull request
Mar 17, 2015
refactored core-tests into separate sub-project
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created a separate sub-project 'summingbird-core-test'