-
Notifications
You must be signed in to change notification settings - Fork 267
Conversation
I have commented Two tests to get a green build for now. One of them is failing and other just hangs. Both of them are in batch/scalding layer |
If you're going to take this approach can you make a pull request based on Also, I wonder when they started failing? Are they broken locally with On Saturday, February 14, 2015, Mansur Ashraf notifications@github.com
Oscar Boykin :: @posco :: http://twitter.com/posco |
they are failing locally as well. Not sure when it started happening but I will enable them in this branch and then we can take a look at them |
It would be good not to move things into test that we don't need to because the test coverage tools can't handle testing moduleA in moduleB, so it lowers our reported test coverage. Here the ExpressionDag stuff and the Dependants tests don't need to be moved as far as I can tell. They are not abstract test harnesses, but instead concrete tests for code in core. Let's leave that (and anything similar) in core/src/test. |
There was too much going on in this PR so I have split it into 3 different PRs
|
* kill fromintlike * add types
Change travis config to make tests run in parallel. Increase heap to 2 gb and permgem to 512mb. Goog news is that storm-tests are finally passing. Bad news is that there is a legit test failure in summingbird-scalding-test and summingbird-batch build just hangs (even locally)