Skip to content
This repository has been archived by the owner on Jan 20, 2022. It is now read-only.

Fix tests #594

Closed
wants to merge 14 commits into from
Closed

Fix tests #594

wants to merge 14 commits into from

Conversation

MansurAshraf
Copy link
Contributor

Change travis config to make tests run in parallel. Increase heap to 2 gb and permgem to 512mb. Goog news is that storm-tests are finally passing. Bad news is that there is a legit test failure in summingbird-scalding-test and summingbird-batch build just hangs (even locally)

screen shot 2015-02-14 at 10 23 34 am

@MansurAshraf
Copy link
Contributor Author

I have commented Two tests to get a green build for now. One of them is failing and other just hangs. Both of them are in batch/scalding layer

@johnynek
Copy link
Collaborator

If you're going to take this approach can you make a pull request based on
this branch that re enables both? We need to get the both green.

Also, I wonder when they started failing? Are they broken locally with
0.6.0 which we just released?

On Saturday, February 14, 2015, Mansur Ashraf notifications@github.com
wrote:

I have commented Two tests to get a green build for now. One of them is
failing and other just hangs. Both of them are in batch/scalding layer


Reply to this email directly or view it on GitHub
#594 (comment).

Oscar Boykin :: @posco :: http://twitter.com/posco

@MansurAshraf
Copy link
Contributor Author

they are failing locally as well. Not sure when it started happening but I will enable them in this branch and then we can take a look at them

@johnynek
Copy link
Collaborator

It would be good not to move things into test that we don't need to because the test coverage tools can't handle testing moduleA in moduleB, so it lowers our reported test coverage. Here the ExpressionDag stuff and the Dependants tests don't need to be moved as far as I can tell. They are not abstract test harnesses, but instead concrete tests for code in core. Let's leave that (and anything similar) in core/src/test.

@MansurAshraf
Copy link
Contributor Author

There was too much going on in this PR so I have split it into 3 different PRs

  1. core-test separation PR refactored core-tests into separate sub-project  #593
  2. parallel build with commented failing tests Enable parallel builds  #599
  3. parallel build with failing tests Re-enable failing tests #598

snoble pushed a commit to snoble/summingbird that referenced this pull request Sep 8, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants