Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The new X button doesn't close the website #1876

Open
grumpycoderpt opened this issue Jul 24, 2023 · 68 comments
Open

The new X button doesn't close the website #1876

grumpycoderpt opened this issue Jul 24, 2023 · 68 comments

Comments

@grumpycoderpt
Copy link

Describe the bug
So a new close button popup today on the website and it doesn't work, instead of closing the website it redirects the user to the homepage.
I know it is not regarding the algorithm but this place seemed appropriated to report a bug issue.

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://www.twitter.com
  2. Click on top left X button
  3. See error

Expected behavior
The tab should close, as good UX teach us.

Environment
Windows Chrome latest version, also Mac OS and iOS 14 Safari.

@Hydraulisch
Copy link

STOP

@BlackFrankFTM2
Copy link

got this issue too, here's hoping it gets resolved soon! 🙏

@xrayian
Copy link

xrayian commented Jul 25, 2023

It's always a delight to visit this repo

@sreeniSudharsan
Copy link

it's a new feature

@abb128
Copy link

abb128 commented Jul 26, 2023

I got fed up waiting for a fix so I made a userscript that patches this as a temporary workaround. I haven't been able to test it thoroughly but hopefully someone finds it useful

https://greasyfork.org/en/scripts/471742-fix-x-button

@bogzxo
Copy link

bogzxo commented Jul 26, 2023

twitter has official become unusable with these bugs…

@abuseofnotation
Copy link

Try :q!

@Kusanalee
Copy link

extremely concerning ‼️

@mstdn
Copy link

mstdn commented Jul 27, 2023

Twitter is one big bug these days

No solving that one

@BidTheArt
Copy link

Can confirm this bug also for Firefox ESR 115 on Debian GNU/Linux 12

@tonytins
Copy link

Knew this rebrand was going to screw everything over.

@CleoMenezesJr
Copy link

Any news about this? I had to shut down my computer in order to leave the site.

@PEPSIMANTR
Copy link

I also have the same bug on Chromium 115 since days.

@erkinalp
Copy link

Out of scope
This repository covers the recommendation algorithm, not the client UI

@AegonOfDragonstone
Copy link

Works on my machine

@Goldmaster
Copy link

Looking into it!

@RedshiftDrift
Copy link

Same bug here https://X.com

Environment
Firefox 115.0.2 on Windows 10.

@thalx99
Copy link

thalx99 commented Jul 27, 2023

Same bug here

@FlipperPA
Copy link

Tested, proven workaround: never visit that dumpster fire of a website again. Delete the app too.

@Inderix
Copy link

Inderix commented Jul 27, 2023

Can reproduce, on Firefox for Android and Firefox for Fedora Linux and OpenSUSE Tumbleweed.

@RoootTheFox
Copy link

can confirm for Firefox 115.0.2-1 on Arch Linux x86_64

@d-bucur
Copy link

d-bucur commented Jul 27, 2023

Also I would like to add that the X logo in the top left is a different font from the official logo

@turb
Copy link

turb commented Jul 27, 2023

My two cents: maybe someone deployed by mistake the native X.org client app. Would definitely join xeyes and xsnow in the ultimate app package.

@wallentx
Copy link


𝕏 ohyou

@MrBruz
Copy link

MrBruz commented Jul 27, 2023

Can confirm this issue occurs on both OpenBSD and Windows XP 😭

@Undercoverdog
Copy link

Works on my machine

Well, we are not handing your machine to all other users tho

@april
Copy link

april commented Jul 27, 2023

I'm having the opposite problem of OP — for the last couple days, my Twitter tabs have had two close buttons. Is it possible that it's related to the same bug?

I've attached a screenshot it case it might be helpful to the developers.

image

@ghost
Copy link

ghost commented Jul 27, 2023

having the same problem on chrome:

Screen Shot 2023-07-28 at 02 24 27

@AtaxyaNetwork
Copy link

If the :q!, as suggested by @abuseofnotation doesn't work, you can try the Emacs way: C-x C-c

@Meaticus22
Copy link

If the :q!, as suggested by @abuseofnotation doesn't work, you can try the Emacs way: C-x C-c

Ewww eMacs

@sai6855
Copy link

sai6855 commented Jul 28, 2023

Elon: LTGM

@xDEADC0DE
Copy link

𝕏 ohyou

Now that’s a retro meme

@ItMaga
Copy link

ItMaga commented Jul 28, 2023

Tweets in GitHub issues is new level

@revskill10
Copy link

document.querySelector("X").on('click', chrome.closeCurrentTab())

Type in your console.

@ejaz4
Copy link

ejaz4 commented Jul 28, 2023

Can confirm this is a problem. Does happen on Firefox 112 as well. I did some investigating and it looks like on some clients it redirects to the home screen and on others it goes right to the top depending on the platform.

I think we should consider this could be a problem with the Web Environment Integrity API not being implemented properly as it might think that the browser is not capable of closing the tab thus crashing and restarting the React app back to "/".

Twitter Devs should consider checking their setup of it here https://github.com/RupertBenWiser/Web-Environment-Integrity and make sure it's all setup properly. As the technology is new it might accidentally class the browser wrong so you should ideally be using navigator.* as a fallback.

@meduzen
Copy link

meduzen commented Jul 28, 2023

Environment Windows Chrome latest version, also Mac OS and iOS 14 Safari.

Please make sure you update your browser to the latest version, which is Safari XVI.

@xtexChooser
Copy link

lgtm, pls fix it

@ho1ger
Copy link

ho1ger commented Jul 29, 2023

The problem spread to iOS. When I click on the "x" in the upper right corner of my device, a weird, twitter-like app opens!

image

@luigiMinardi
Copy link

Oh yeah... the TeX $\mathbb{X}$

@emp3826
Copy link

emp3826 commented Jul 30, 2023

same bug exists on Chrome115

@wdbacker
Copy link

This bug is spreading further, not only on browsers but now also on the android app. In addition, the "close button" moved to the center of the app header bar, making the UI experience even worse as users are more forced to close this app immediately.

@ghost
Copy link

ghost commented Jul 30, 2023

Can confirm this is a problem. Does happen on Firefox 112 as well. I did some investigating and it looks like on some clients it redirects to the home screen and on others it goes right to the top depending on the platform.

I think we should consider this could be a problem with the Web Environment Integrity API not being implemented properly as it might think that the browser is not capable of closing the tab thus crashing and restarting the React app back to "/".

Twitter Devs should consider checking their setup of it here https://github.com/RupertBenWiser/Web-Environment-Integrity and make sure it's all setup properly. As the technology is new it might accidentally class the browser wrong so you should ideally be using navigator.* as a fallback.

https://github.com/Young-Lord/fight-for-the-open-web

@ghost
Copy link

ghost commented Jul 30, 2023

I got fed up waiting for a fix so I made a userscript that patches this as a temporary workaround. I haven't been able to test it thoroughly but hopefully someone finds it useful

https://greasyfork.org/en/scripts/471742-fix-x-button

You should make the fallback message look like this instead: https://yewtu.be/watch?v=p7HzFXoZQ4k

@Sylicium
Copy link

Sylicium commented Jul 30, 2023

There is a patch for it !!!

@grumpycoderpt
Go see this repo to download the Chrome extension: https://github.com/Sylicium/twitter-x-button-patch/releases/tag/0.1.0
Hope this will help you all with this really weird and unpatch bug !

@CleoMenezesJr there is some news for you :D

@Boyban
Copy link

Boyban commented Jul 31, 2023

Quick fix

document.querySelector('H1').onclick = () => window.close();

@mbarnathan
Copy link

If you close this issue, it will become more powerful (and self-referential) than you can possibly imagine

@RoootTheFox
Copy link

this issue should be pinned for visibility actually. most users have problems with that X button and can find workarounds in here

@HunteRoi
Copy link

HunteRoi commented Aug 7, 2023

Quick fix

document.querySelector('H1').onclick = () => window.close();

This one works better : window.onload = () => window.close();. Tested and approved 👍

@fanfare
Copy link

fanfare commented Aug 8, 2023

today, i just clicked on the X for real trying to go back to the previous page for real

@april
Copy link

april commented Aug 8, 2023

@fanfare: we're all here because we clicked on the X for real, please treat this issue with the proper respect and seriousness that it deserves.

@kir0ul
Copy link

kir0ul commented Aug 8, 2023

@fanfare
Copy link

fanfare commented Aug 9, 2023

@fanfare: we're all here because we clicked on the X for real, please treat this issue with the proper respect and seriousness that it deserves.

my accidentally clicking the X a moment ago is technically a separate issue from the OP (i was trying to go "back" after opening a tweet -- confusing the functionality of the "X" with the functionality of the site's "left" arrow [1] -- and not trying to "close the website" (this confusion likely stems from other sides having "X" buttons to dismiss the current active page and go back, e.g. USA Today [2])). I doubt this separate confusion warrants a new issue, however, I would be happy to open one or even several more new issues on the topic if necessary.

separately, i have done some reflection and agree that my using the phrase "for real" was dismissive and insensitive, and for that i offer my deepest apologies...

  1. confusion

  2. USA Today

@Kusanalee
Copy link

Kusanalee commented Aug 9, 2023 via email

@Bracket-H
Copy link

Calling this retarded and hostile toward users would do a whole lot more good than interpreting it as a joke.

But alas. I'm having correspondence with twitter users right now, so you probably checked out at the third word of this comment and got your pitchforks ready out of fear of punishment for not punishing the usage of that term.

Alas, alas.

@7Doyo
Copy link

7Doyo commented Aug 21, 2023

X Twitters overflow-github

@ghost
Copy link

ghost commented Dec 28, 2023

can confirm on grub/gnu/linux/systemd/lenovo/intel/nixos/x86_64/gpl/nix/nvidia/zsh/ext4/sddm/wayland/kde/qt5/ using the Firefox browser (version 120.0.1 (64-bit)) (Mozilla Firefox for NixOS) (nixos - 1.0) (Firefox is designed by Mozilla, a global community working together to keep the Web open, public and accesible to all.) (Want to help? Make a donation or get involved)
(Licensing Information) (End-User Rights) (Privacy Policy)
(Firefox and the Firefox logos are trademarks of the Mozilla Foundation)

@Soulter
Copy link

Soulter commented Dec 28, 2023

The problem can be reproduced on my Mac(M1 series, 256GB + 16GB).

@CleoMenezesJr
Copy link

Calling this retarded and hostile toward users would do a whole lot more good than interpreting it as a joke.

But alas. I'm having correspondence with twitter users right now, so you probably checked out at the third word of this comment and got your pitchforks ready out of fear of punishment for not punishing the usage of that term.

Alas, alas.

Nice, but could you reproduce the issue?

@Bracket-H
Copy link

Calling this retarded and hostile toward users would do a whole lot more good than interpreting it as a joke.
But alas. I'm having correspondence with twitter users right now, so you probably checked out at the third word of this comment and got your pitchforks ready out of fear of punishment for not punishing the usage of that term.
Alas, alas.

Nice, but could you reproduce the issue?

No, I cannot reproduce it anymore since I blocked that entire embarrassment of a website from my life and I can only feel pity for those who for whatever reason have to keep using it.

@egeres
Copy link

egeres commented Oct 7, 2024

This has to be the one of the funniest issues in all github hahah

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests