Skip to content

fix: Better recommendations on timeline. #17

Closed
abstraq wants to merge 1 commit into
twitter:mainfrom
abstraq:main
Closed

fix: Better recommendations on timeline. #17
abstraq wants to merge 1 commit into
twitter:mainfrom
abstraq:main

Conversation

@abstraq
Copy link
Copy Markdown

@abstraq abstraq commented Mar 31, 2023

No description provided.

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Mar 31, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@pizzaboxer
Copy link
Copy Markdown

pizzaboxer commented Mar 31, 2023

+1 i think this would contribute a lot to the twitter experience

@bluepilledgreat
Copy link
Copy Markdown

bluepilledgreat commented Mar 31, 2023

LGTM

@abstraq abstraq changed the title fix: Better reccommendations on timeline. (#1) fix: Better recommendations on timeline. Mar 31, 2023
@ferothefox
Copy link
Copy Markdown

ferothefox commented Mar 31, 2023

This is production-ready.

@raven0034
Copy link
Copy Markdown

raven0034 commented Mar 31, 2023

It's too close, fight harder

@bansaldehyde
Copy link
Copy Markdown

bansaldehyde commented Mar 31, 2023

This is actually good. +1

@nonetrix
Copy link
Copy Markdown

nonetrix commented Mar 31, 2023

lgtm

@breakzplatform
Copy link
Copy Markdown

breakzplatform commented Mar 31, 2023

gread pr, +1

@jowrjowr
Copy link
Copy Markdown

jowrjowr commented Mar 31, 2023

CI has passed. ship it.

@NiciusB
Copy link
Copy Markdown

NiciusB commented Mar 31, 2023

LGTM!

@xiaohk
Copy link
Copy Markdown

xiaohk commented Mar 31, 2023

:shipit: :shipit: :shipit: :shipit: :shipit: :shipit: :shipit: :shipit: :shipit: :shipit: :shipit: :shipit:
:shipit: :shipit: :shipit: :shipit: :shipit: :shipit: :shipit: :shipit: :shipit: :shipit: :shipit: :shipit:
:shipit: :shipit: :shipit: :shipit: :shipit: :shipit: :shipit: :shipit: :shipit: :shipit: :shipit: :shipit:
:shipit: :shipit: :shipit: :shipit: :shipit: :shipit: :shipit: :shipit: :shipit: :shipit: :shipit: :shipit:
:shipit: :shipit: :shipit: :shipit: :shipit: :shipit: :shipit: :shipit: :shipit: :shipit: :shipit: :shipit:

@WouterStulp
Copy link
Copy Markdown

WouterStulp commented Mar 31, 2023

LGTM!

@mahapsub
Copy link
Copy Markdown

mahapsub commented Mar 31, 2023

🐝

@wmorgue
Copy link
Copy Markdown

wmorgue commented Mar 31, 2023

Looks good 👍

@lucasnethaj
Copy link
Copy Markdown

lucasnethaj commented Mar 31, 2023

wise words sir

@vexorian
Copy link
Copy Markdown

vexorian commented Mar 31, 2023

It makes the most sense.

@neverabsolute
Copy link
Copy Markdown

neverabsolute commented Mar 31, 2023

lgtm

@im-alfa
Copy link
Copy Markdown

im-alfa commented Mar 31, 2023

legend

@GalvinPython
Copy link
Copy Markdown

GalvinPython commented Mar 31, 2023

I like this change

@mohammedsahl
Copy link
Copy Markdown

mohammedsahl commented Mar 31, 2023

LGTM ship it!

aashari
aashari reviewed Mar 31, 2023
View reviewed changes
Copy link
Copy Markdown

@aashari aashari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pinguinosod
Copy link
Copy Markdown

pinguinosod commented Mar 31, 2023

Top 💯💯💯🤌🤌

@aadtyn
Copy link
Copy Markdown

aadtyn commented Mar 31, 2023

:shipit: 💀

@HyflerSD
Copy link
Copy Markdown

HyflerSD commented Mar 31, 2023 •
edited
Loading

-1 makes more sense but this is still good!
better yet maybe a floating point

@ts-3156
Copy link
Copy Markdown

ts-3156 commented Mar 31, 2023

The best PR ever

@monospacedigital
Copy link
Copy Markdown

monospacedigital commented Mar 31, 2023

Lgtm

davidkrammer
davidkrammer reviewed Mar 31, 2023
View reviewed changes
Copy link
Copy Markdown

@davidkrammer davidkrammer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dont change it to 0. Instead better rank blue verfied way higher 🚀

@witcheslive
Copy link
Copy Markdown

witcheslive commented Mar 31, 2023

These are the kind of improvements we're looking for in open sourcing the algorithm. Deploy immediately.

@kehrazy
Copy link
Copy Markdown

kehrazy commented Apr 1, 2023

LGTM

@raftario
Copy link
Copy Markdown

raftario commented Apr 1, 2023

i assume closing this was a mistake, should probably reopen. lgtm

@RetroDreams
Copy link
Copy Markdown

RetroDreams commented Apr 1, 2023

Be sure to go tell @martianoff on Twitter how you feel about him closing this PR

@RinLovesYou
Copy link
Copy Markdown

RinLovesYou commented Apr 1, 2023

Imagine closing a legitimate PR like this without giving any reason. Twitter recommending me unfunny people who have paid their way into my timeline is ridiculous. My for you should consist of people i follow, their likes, and similar content. I do not care for promotion of funny "premium" users. They have their audience, they don't need the extra reach.

@kururuchan
Copy link
Copy Markdown

kururuchan commented Apr 1, 2023

LGTM from me.

@TheDukeDK
Copy link
Copy Markdown

TheDukeDK commented Apr 1, 2023

CI has passed. ship it.

🤣
image

NeelAPatel
NeelAPatel reviewed Apr 1, 2023
View reviewed changes
Copy link
Copy Markdown

@NeelAPatel NeelAPatel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unsure why this is closed, the proposed changes would indeed give back the reverse chronological order of tweets we desire.

Transparency and honesty used to be the bread and butter of twitter before The Algorithm.

Must merge immediately post haste, LGTM 🚀

@maxix54
Copy link
Copy Markdown

maxix54 commented Apr 1, 2023

LGTM, reopen this.

@addisonlynch
Copy link
Copy Markdown

addisonlynch commented Apr 1, 2023

LGTM

1 similar comment
@evergreenbear
Copy link
Copy Markdown

evergreenbear commented Apr 1, 2023

LGTM

@sidedwards
Copy link
Copy Markdown

sidedwards commented Apr 1, 2023

LGTM :shipit:

@AlexFlipnote
Copy link
Copy Markdown

AlexFlipnote commented Apr 1, 2023

LGTM 👍👍

@ghost
Copy link
Copy Markdown

ghost commented Apr 1, 2023

+1

@richardjohn
Copy link
Copy Markdown

richardjohn commented Apr 1, 2023

Ship it! 🚀

@fabrb
Copy link
Copy Markdown

fabrb commented Apr 1, 2023

LGTM 🚀

@erickdewa
Copy link
Copy Markdown

erickdewa commented Apr 1, 2023

It is better😂🤌

Zurga
Zurga reviewed Apr 1, 2023
View reviewed changes
Copy link
Copy Markdown

@Zurga Zurga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

santumerino
santumerino reviewed Apr 1, 2023
View reviewed changes
Copy link
Copy Markdown

@santumerino santumerino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can only assume that this PR was closed by mistake. This looks like a clear improvement to me.

hexandcube
hexandcube reviewed Apr 1, 2023
View reviewed changes
Copy link
Copy Markdown

@hexandcube hexandcube left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 This is a great improvement to The Algorithm™ which will make Twitter a lot better

@cperdiansyah
Copy link
Copy Markdown

cperdiansyah commented Apr 1, 2023

LGTM 🚀

onedr0p
onedr0p reviewed Apr 1, 2023
View reviewed changes
Copy link
Copy Markdown

@onedr0p onedr0p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

nouraellm
nouraellm reviewed Apr 1, 2023
View reviewed changes
Copy link
Copy Markdown

@nouraellm nouraellm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LFGTM!

@rutkk
Copy link
Copy Markdown

rutkk commented Apr 1, 2023

LGTM

@adrianarandac
Copy link
Copy Markdown

adrianarandac commented Apr 2, 2023

Quality PR in here

thomiceli
thomiceli reviewed Apr 2, 2023
View reviewed changes
Copy link
Copy Markdown

@thomiceli thomiceli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelmerk
Copy link
Copy Markdown

jelmerk commented Apr 3, 2023

LGTM

@synap5e
Copy link
Copy Markdown

synap5e commented May 2, 2023

How do I install this version of twitter? Is this repo missing a releases page?

@WeGoToMars
Copy link
Copy Markdown

WeGoToMars commented May 23, 2023

This should be №1 in the issue list by the number of comments. LGTM!

@Haaroon
Copy link
Copy Markdown

Haaroon commented May 24, 2023

LGTM how to approve?

@rburhum
Copy link
Copy Markdown

rburhum commented May 24, 2023

LGTM how to approve?

I approve it. Who else wants to approve it? Ship it! lol

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

24 more reviewers

@onedr0p onedr0p onedr0p left review comments

@twofactor twofactor twofactor left review comments

@blainehoyt blainehoyt blainehoyt left review comments

@cjwillia cjwillia cjwillia left review comments

@zroyer zroyer zroyer left review comments

@aashari aashari aashari left review comments

@cbackas cbackas cbackas left review comments

@Zurga Zurga Zurga left review comments

@NeelAPatel NeelAPatel NeelAPatel left review comments

@shadeofsound shadeofsound shadeofsound left review comments

@rmcmk rmcmk rmcmk left review comments

@3zachm 3zachm 3zachm left review comments

@KevinDenys KevinDenys KevinDenys left review comments

@yellowsink yellowsink yellowsink left review comments

@coreyg142 coreyg142 coreyg142 left review comments

@nouraellm nouraellm nouraellm left review comments

@willbrandin willbrandin willbrandin left review comments

@thomiceli thomiceli thomiceli left review comments

@TheDevMinerTV TheDevMinerTV TheDevMinerTV left review comments

@santumerino santumerino santumerino left review comments

@lRaulMN7 lRaulMN7 lRaulMN7 left review comments

@Rotinx Rotinx Rotinx left review comments

@hexandcube hexandcube hexandcube left review comments

@davidkrammer davidkrammer davidkrammer left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.