Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Better recommendations on timeline. #17

Closed
wants to merge 1 commit into from
Closed

fix: Better recommendations on timeline. #17

wants to merge 1 commit into from

Conversation

abstraq
Copy link

@abstraq abstraq commented Mar 31, 2023

No description provided.

@CLAassistant
Copy link

CLAassistant commented Mar 31, 2023

CLA assistant check
All committers have signed the CLA.

@pizzaboxer
Copy link

+1 i think this would contribute a lot to the twitter experience

@bluepilledgreat
Copy link

LGTM

@abstraq abstraq changed the title fix: Better reccommendations on timeline. (#1) fix: Better recommendations on timeline. Mar 31, 2023
@ferothefox
Copy link

This is production-ready.

@raven0034
Copy link

It's too close, fight harder

@ShauryaB537
Copy link

This is actually good. +1

@nonetrix
Copy link

lgtm

@breakzplatform
Copy link

gread pr, +1

@jowrjowr
Copy link

CI has passed. ship it.

@NiciusB
Copy link

NiciusB commented Mar 31, 2023

LGTM!

@xiaohk
Copy link

xiaohk commented Mar 31, 2023

:shipit: :shipit: :shipit: :shipit: :shipit: :shipit: :shipit: :shipit: :shipit: :shipit: :shipit: :shipit:
:shipit: :shipit: :shipit: :shipit: :shipit: :shipit: :shipit: :shipit: :shipit: :shipit: :shipit: :shipit:
:shipit: :shipit: :shipit: :shipit: :shipit: :shipit: :shipit: :shipit: :shipit: :shipit: :shipit: :shipit:
:shipit: :shipit: :shipit: :shipit: :shipit: :shipit: :shipit: :shipit: :shipit: :shipit: :shipit: :shipit:
:shipit: :shipit: :shipit: :shipit: :shipit: :shipit: :shipit: :shipit: :shipit: :shipit: :shipit: :shipit:

@WouterStulp
Copy link

LGTM!

@mahapsub
Copy link

🐝

@wmorgue
Copy link

wmorgue commented Mar 31, 2023

Looks good 👍

@lucasnethaj
Copy link

wise words sir

@vexorian
Copy link

It makes the most sense.

@neverabsolute
Copy link

lgtm

@im-alfa
Copy link

im-alfa commented Mar 31, 2023

legend

@GalvinPython
Copy link

I like this change

@mohammedsahl
Copy link

LGTM ship it!

Copy link

@aashari aashari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pinguinosod
Copy link

Top 💯💯💯🤌🤌

@soulninja-dev
Copy link

:shipit: 💀

@HyflerSD
Copy link

HyflerSD commented Mar 31, 2023

-1 makes more sense but this is still good!
better yet maybe a floating point

@ts-3156
Copy link

ts-3156 commented Mar 31, 2023

The best PR ever

@monospacedigital
Copy link

Lgtm

Copy link

@davidkrammer davidkrammer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dont change it to 0. Instead better rank blue verfied way higher 🚀

@witcheslive
Copy link

These are the kind of improvements we're looking for in open sourcing the algorithm. Deploy immediately.

@kehrazy
Copy link

kehrazy commented Apr 1, 2023

LGTM

@raftario
Copy link

raftario commented Apr 1, 2023

i assume closing this was a mistake, should probably reopen. lgtm

@RetroDreams
Copy link

Be sure to go tell @martianoff on Twitter how you feel about him closing this PR

@RinLovesYou
Copy link

Imagine closing a legitimate PR like this without giving any reason. Twitter recommending me unfunny people who have paid their way into my timeline is ridiculous. My for you should consist of people i follow, their likes, and similar content. I do not care for promotion of funny "premium" users. They have their audience, they don't need the extra reach.

@kururuchan
Copy link

LGTM from me.

@TheDukeDK
Copy link

CI has passed. ship it.

🤣
image

Copy link

@NeelAPatel NeelAPatel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unsure why this is closed, the proposed changes would indeed give back the reverse chronological order of tweets we desire.

Transparency and honesty used to be the bread and butter of twitter before The Algorithm.

Must merge immediately post haste, LGTM 🚀

@maxix54
Copy link

maxix54 commented Apr 1, 2023

LGTM, reopen this.

@addisonlynch
Copy link

LGTM

1 similar comment
@evergreenbear
Copy link

LGTM

@sidedwards
Copy link

LGTM :shipit:

@AlexFlipnote
Copy link

LGTM 👍👍

@ghost
Copy link

ghost commented Apr 1, 2023

+1

@richardjohn
Copy link

Ship it! 🚀

@fabrb
Copy link

fabrb commented Apr 1, 2023

LGTM 🚀

@erickdewa
Copy link

It is better😂🤌

Copy link

@Zurga Zurga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link

@santumerino santumerino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can only assume that this PR was closed by mistake. This looks like a clear improvement to me.

Copy link

@hexandcube hexandcube left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 This is a great improvement to The Algorithm™ which will make Twitter a lot better

@cperdiansyah
Copy link

LGTM 🚀

Copy link

@onedr0p onedr0p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

Copy link

@nouraellm nouraellm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LFGTM!

@ableitung
Copy link

LGTM

@adrianarandac
Copy link

Quality PR in here

Copy link

@thomiceli thomiceli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelmerk
Copy link

jelmerk commented Apr 3, 2023

LGTM

@synap5e
Copy link

synap5e commented May 2, 2023

How do I install this version of twitter? Is this repo missing a releases page?

@WeGoToMars
Copy link

This should be №1 in the issue list by the number of comments. LGTM!

@Haaroon
Copy link

Haaroon commented May 24, 2023

LGTM how to approve?

@rburhum
Copy link

rburhum commented May 24, 2023

LGTM how to approve?

I approve it. Who else wants to approve it? Ship it! lol

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.