Skip to content

Conversation

Cosmelon
Copy link

@Cosmelon Cosmelon commented Apr 1, 2023

took care of some backend optimizations to increase algorithm workflow

@Killjoyer
Copy link

Thanks for the contribution!
But i think your code lacks tests

@Y2KForever
Copy link

LGTM 🔥

@aldy97
Copy link

aldy97 commented Apr 1, 2023

LGTM

@ryanmattos
Copy link

It seems to work for me

@dzikrisyairozi
Copy link

image

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@Cosmelon
Copy link
Author

Cosmelon commented Apr 1, 2023

Thanks for the contribution! But i think your code lacks tests

Thanks for the feedback, I added further optimizations to make the need for tests unnecessary.

@nobodyindustries
Copy link

image

@poleshe
Copy link

poleshe commented Apr 1, 2023

LGTM

@kadeksuryam
Copy link

What a bunch of kids

@Cosmelon
Copy link
Author

Cosmelon commented Apr 1, 2023

You know, I'm still looking through some of the code I've re-written, and come to think of it I actually have further progress to make, will be updating as I fix.

@ScribbleDribble
Copy link

LGTM

@rdnsyh
Copy link

rdnsyh commented Apr 1, 2023

bug free code, ship it!! 🚀🚀

@leonidlist
Copy link

LGTM

@SaltfishAmi
Copy link

lgtm

@nrmu9
Copy link

nrmu9 commented Apr 1, 2023

LGTM

5 similar comments
@ANormalProgrammer
Copy link

LGTM

@parnexcodes
Copy link

LGTM

@kyeboard
Copy link

kyeboard commented Apr 3, 2023

LGTM

@wolfvandenbussche
Copy link

LGTM

@kdata12
Copy link

kdata12 commented Apr 3, 2023

LGTM

@eschwart
Copy link

eschwart commented Apr 3, 2023

I don't see anything wrong with it. LGTM

@ZeroDiscord
Copy link

LGTM

Copy link

@Brendan5536 Brendan5536 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work. Can’t seem to find any bugs.

@pgh268400
Copy link

Code stripping is a great optimization technique

@helderpgoncalves
Copy link

Took some time to review it. But yes LGTM!

Copy link

@xkstndua15 xkstndua15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🔥

@happytalkSU
Copy link

LGTM

@gokayumutlu
Copy link

I am sure It would run instantly just like there is nothing to compile after these changes.

@wodnjse
Copy link

wodnjse commented Apr 8, 2023

LGBT

@ghost
Copy link

ghost commented Apr 12, 2023

LGTM

@ashley0143
Copy link

LGTM, idk why its still not merged tho

@mm12
Copy link

mm12 commented Jun 27, 2024

LGTM

@Cosmelon Cosmelon closed this by deleting the head repository Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.