-
Notifications
You must be signed in to change notification settings - Fork 12.2k
optimized the algorithm #910
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for the contribution! |
LGTM 🔥 |
LGTM |
It seems to work for me |
|
Thanks for the feedback, I added further optimizations to make the need for tests unnecessary. |
LGTM |
What a bunch of kids |
You know, I'm still looking through some of the code I've re-written, and come to think of it I actually have further progress to make, will be updating as I fix. |
LGTM |
bug free code, ship it!! 🚀🚀 |
LGTM |
lgtm |
LGTM |
5 similar comments
LGTM |
LGTM |
LGTM |
LGTM |
LGTM |
I don't see anything wrong with it. LGTM |
LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work. Can’t seem to find any bugs.
Code stripping is a great optimization technique |
Took some time to review it. But yes LGTM! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🔥
LGTM |
I am sure It would run instantly just like there is nothing to compile after these changes. |
LGBT |
LGTM |
LGTM, idk why its still not merged tho |
LGTM |
took care of some backend optimizations to increase algorithm workflow