Exposes the AVAudioPlayer instance method setVolume(_:fadeDuration:) and adds completion handler to play method. #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… This allows to set the volume of a specific sound or all sounds with the option to specify the fade duration.
- Modified `play` method to accept an optional completion handler that is executed when a sound finishes playing. - Updated `stop` method to remove the associated completion handler when a sound is stopped before it finishes. - Revised DocC comments for `play`, `stop`, and `audioPlayerDidFinishPlaying` methods to accurately reflect the changes in functionality.
coderExMachina
changed the title
|
Thank you for this! I like the idea, but I'm not sure what's going on with all the whitespace changes, and the |
|
Thanks for your comment! My reasoning for using DispatchQueue.main.async { } was that the completion handler might interact with the UI. Hence I thought it would be necessary to use it. Could you let me know what part makes you feel uneasy? Id be happy to adapt the solution. (As for the whitespace: This must have happened when I let Xcode re-indent my code - I can revert that. Cheers! |
|
I have made a couple of changes now, that hopefully address your concerns. Let me know what you think! Thanks :) |
…om SwiftUI views.
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows to set the volume of a specific sound or all sounds with the option to specify the fade duration and adds a completion handler to the play method.