Ensure wait_for_job accepts a job_id as well as a resource #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good, but I don't like the indentation changes. |
|
Presume you mean aneilbaboo@280d8a5 What do you suggest instead? (As a single line it fails flake8) |
|
The only flake8 failures I'm seeing in master are the unused imports in |
|
$ flake8 --version |
|
My full flake8 output: $ flake8
./bigquery/__init__.py:8:1: F401 'get_client' imported but unused
./bigquery/__init__.py:9:1: F401 'BIGQUERY_SCOPE' imported but unused
./bigquery/__init__.py:9:1: F401 'BIGQUERY_SCOPE_READ_ONLY' imported but unused
./bigquery/__init__.py:9:1: F401 'JOB_CREATE_IF_NEEDED' imported but unused
./bigquery/__init__.py:9:1: F401 'JOB_CREATE_NEVER' imported but unused
./bigquery/__init__.py:9:1: F401 'JOB_ENCODING_ISO_8859_1' imported but unused
./bigquery/__init__.py:9:1: F401 'JOB_ENCODING_UTF_8' imported but unused
./bigquery/__init__.py:9:1: F401 'JOB_SOURCE_FORMAT_CSV' imported but unused
./bigquery/__init__.py:9:1: F401 'JOB_SOURCE_FORMAT_DATASTORE_BACKUP' imported but unused
./bigquery/__init__.py:9:1: F401 'JOB_SOURCE_FORMAT_NEWLINE_DELIMITED_JSON' imported but unused
./bigquery/__init__.py:9:1: F401 'JOB_WRITE_APPEND' imported but unused
./bigquery/__init__.py:9:1: F401 'JOB_WRITE_EMPTY' imported but unused
./setup.py:29:1: W391 blank line at end of file
./bigquery/__init__.py:9:1: F401 'JOB_WRITE_TRUNCATE' imported but unused
./bigquery/__init__.py:22:1: F401 'schema_from_record' imported but unused
./bigquery/tests/test_client.py:493:32: E126 continuation line over-indented for hanging indent
./bigquery/tests/test_client.py:496:28: E126 continuation line over-indented for hanging indent
./bigquery/tests/test_client.py:741:32: E126 continuation line over-indented for hanging indent
./bigquery/tests/test_client.py:744:28: E126 continuation line over-indented for hanging indent
./bigquery/tests/test_client.py:838:32: E126 continuation line over-indented for hanging indent
./bigquery/tests/test_client.py:841:28: E126 continuation line over-indented for hanging indent
./bigquery/tests/test_client.py:929:32: E126 continuation line over-indented for hanging indent
./bigquery/tests/test_client.py:932:28: E126 continuation line over-indented for hanging indent
./bigquery/tests/test_client.py:976:48: E126 continuation line over-indented for hanging indent
./bigquery/tests/test_client.py:977:80: E501 line too long (80 > 79 characters)
./bigquery/tests/test_client.py:981:44: E126 continuation line over-indented for hanging indent
./bigquery/tests/test_client.py:996:48: E126 continuation line over-indented for hanging indent
./bigquery/tests/test_client.py:1000:44: E126 continuation line over-indented for hanging indent |
|
Right, the |
blarghmatey
pushed a commit
to blarghmatey/BigQuery-Python
that referenced
this pull request
Jul 9, 2015
Added support for tox to execute tests against multiple python version Added patch to support `job_id` in `wait_for_job` <tylertreat#29>
blarghmatey
pushed a commit
to blarghmatey/BigQuery-Python
that referenced
this pull request
Jul 9, 2015
Added support for tox to execute tests against multiple python version Added patch to support `job_id` in `wait_for_job` <tylertreat#29>
blarghmatey
pushed a commit
to blarghmatey/BigQuery-Python
that referenced
this pull request
Jul 9, 2015
Added support for tox to execute tests against multiple python version Added patch to support `job_id` in `wait_for_job` <tylertreat#29>
blarghmatey
pushed a commit
to blarghmatey/BigQuery-Python
that referenced
this pull request
Jul 9, 2015
Added support for tox to execute tests against multiple python version Added patch to support `job_id` in `wait_for_job` <tylertreat#29>
|
Fixed with #61. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for client.wait_for_job('jobId').