Skip to content

Conversation

pirsquare
Copy link
Contributor

  • Supports reading query results with multiple pages for get_query_rows
  • Make get_query_results public
  • Add missing get_dataset method
  • Add check_dataset

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might want to add a note in the docstring of this method that it will append each page of results, which is potentially a very expensive call. If users want to manually page through results, they can use get_query_results. I think in general, we should probably make the docstrings of get_query_rows and get_query_results more detailed since it might not be obvious what the difference between the two is.

@tylertreat
Copy link
Owner

Looks good. Just one note about making the docstrings a bit more clear.

@tylertreat
Copy link
Owner

Thanks!

tylertreat added a commit that referenced this pull request Jun 7, 2015
Support reading query results with multiple pages and other dataset helper methods
@tylertreat tylertreat merged commit 612da17 into tylertreat:master Jun 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants