Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update vscode-uri and match their docs #629

Merged
merged 6 commits into from
Oct 6, 2023

Conversation

NullVoxPopuli
Copy link
Contributor

On projects using 1.2.0 of Glint, they'll run in to this:

file:///home/nvp/Development/NullVoxPopuli/polaris-starter-2/node_modules/.pnpm/@glint+core@1.2.0_typescript@5.2.2/node_modules/@glint/core/lib/language-server/util/index.js:3
import VSCodeURI from 'vscode-uri';
       ^^^^^^^^^
SyntaxError: The requested module 'vscode-uri' does not provide an export named 'default'
    at ModuleJob._instantiate (node:internal/modules/esm/module_job:124:21)
    at async ModuleJob.run (node:internal/modules/esm/module_job:190:5)

Which makes sense since @glint/core didn't declare a dep on vscode-uri.

Locally, when testing, I was using the 1.2.0 version of the language server, / vscode extension, so I don't know if that'll need to be published 🤷

packages/core/package.json Outdated Show resolved Hide resolved
@NullVoxPopuli NullVoxPopuli changed the title Fix @glint/core 1.2.0's missing dependency Update vscode-uri and match their docs Oct 6, 2023
@dfreeman
Copy link
Member

dfreeman commented Oct 6, 2023

Thank you! I'll do a bugfix release shortly so no one else gets bitten by this

@dfreeman dfreeman merged commit 496abc3 into typed-ember:main Oct 6, 2023
4 checks passed
@dfreeman dfreeman added the bug Something isn't working label Oct 6, 2023
@NullVoxPopuli NullVoxPopuli deleted the fix-glint-1-2 branch October 6, 2023 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants