Player match attribute casting #13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- required some updates in validity check. refactored the playerMatch and Insert statement generation according to explosion which made it simpler - done together (less and cleaner code) - added RelationInsertGeneratorTest tests to cover the explosion cases - tests with phone calls (expanded on data to test) work fine - prepared the relation-of-relation in call (creating several calls that will be added by player explosion, the player being a relation in next commits)
… will be set to true automatically
- also added how the configs should look like for relation-of-relations. - created communication-channel.csv data file to add relation-of-relations, one-per-row and exploding the relation - updated schema to include communication-channel relation
…on as it was intended but forgotten...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
solves bug reported in issue-10