Standardize all context manager __exit__ methods #1194
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamchainz
commented
Oct 19, 2022
| @@ -1,5 +1,4 @@ | |||
| import os | |||
| def message(self): ... | ||
| def __enter__(self): ... | ||
| def __exit__(self, exc_type: Any, exc_value: Any, traceback: Any): ... | ||
| def test(self) -> None: ... |
There was a problem hiding this comment.
| def __enter__(self): ... | ||
| def __exit__(self, exc_type: Any, exc_value: Any, traceback: Any): ... | ||
| def test(self) -> None: ... | ||
| def message(self) -> str: ... |
There was a problem hiding this comment.
Removed in Django 4.1, but previously returned a str: django/django@806efe9#diff-7833da5b45a68d00834388d97dd5c4413e3796497c7bc5e0cc2621b08a2d0df1L111
| exc_type: Optional[Type[BaseException]], | ||
| exc_value: Optional[BaseException], | ||
| traceback: Optional[TracebackType], | ||
| ) -> Optional[bool]: ... |
There was a problem hiding this comment.
| @@ -1,5 +1,5 @@ | |||
| from types import TracebackType | |||
| from typing import Any, Dict, Iterable, Iterator, List, Optional, Type | |||
| @@ -1,4 +1,4 @@ | |||
| from contextlib import ContextDecorator, contextmanager | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have made things!
The Django-MySQL test suite uses a subclass of
CaptureQueriesContext, which is how I found its__exit__()method was mistyped. This PR standardizes all__exit__methods to use the correct optional types, and fixes some minor issues on the way.Related issues
n/a