Generic sitemap #1198
Merged
Generic sitemap #1198
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sobolevn
reviewed
Oct 21, 2022
| from django.urls import reverse | ||
| from myapp.models import Offer | ||
|
|
||
| class OfferSitemap(Sitemap): |
There was a problem hiding this comment.
Do you mean
Suggested change
| class OfferSitemap(Sitemap): | |
| class OfferSitemap(Sitemap[Offer]): |
?
There was a problem hiding this comment.
Yeah you're right. I just updated this and the other test.
sobolevn
reviewed
Oct 22, 2022
There was a problem hiding this comment.
We also need a case with
class WrongOfferSitemap(Sitemap[Offer]):
def items() -> BadReturn: ...
def locations(arg: BadArg): ...There was a problem hiding this comment.
Indeed, I've added this
UnknownPlatypus
force-pushed
the
generic_sitemap
branch
from
5ad2cae to
195ad71
Compare
sobolevn
reviewed
Oct 22, 2022
| }, | ||
| ) | ||
|
|
||
| class WrongOfferSitemap(Sitemap[Offer]): |
There was a problem hiding this comment.
One last question: what about GenericSiteMap? Should we test it?
There was a problem hiding this comment.
Yeah I was unsure about this one. I don't know how people are generally using it.
Maybe I should add a case close to the documentation exemple to make sure everything pass ?
sobolevn
reviewed
Oct 22, 2022
There was a problem hiding this comment.
and one more for an incorrect version
UnknownPlatypus
force-pushed
the
generic_sitemap
branch
from
d5722e0 to
73782cf
Compare
|
Thanks for the review 🙌 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have made things!
Implement generic type for the
Sitemapclass and also add the get_latest_lastmod method stub (added in django 4.1)Related issues