-
-
Notifications
You must be signed in to change notification settings - Fork 507
Validation of the fields
argument to bulk_update
#2808
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
sobolevn
merged 6 commits into
typeddjango:master
from
UnknownPlatypus:validate-bulk-update-fields
Oct 5, 2025
Merged
Validation of the fields
argument to bulk_update
#2808
sobolevn
merged 6 commits into
typeddjango:master
from
UnknownPlatypus:validate-bulk-update-fields
Oct 5, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sobolevn
reviewed
Sep 11, 2025
21adeb2
to
0e2adf7
Compare
sobolevn
reviewed
Oct 5, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, also test at least one nested__field
error. It is not supported by django.
Co-authored-by: sobolevn <mail@sobolevn.me>
sobolevn
approved these changes
Oct 5, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have made things!
Mostly mirrors validation logic from
django.db.models.query.QuerySet.bulk_update
.Tests are inspired from
django/tests/queries/test_bulk_update.py
I could have called a dummy
bulk_update
with no objects to reuse django internal logic but it felt brittle with risk of someday actually do database query so I preferred to re-implement the few checks