Allow to annotate existing model field de-selected via prior .values/.values_list calls
#2836
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sobolevn
reviewed
Sep 24, 2025
sobolevn
approved these changes
Oct 4, 2025
mypy_django_plugin/lib/helpers.py
Outdated
| ), | ||
| mod_name=None, | ||
| ) | ||
| else: |
There was a problem hiding this comment.
I've made the change, should we add RET505 from ruff to enforce this convention ?
I can make a followup PR for this, it does affect ~10 files. I also find these valueable:
"RET504", # Unnecessary assignment to {name} before return statement
"RET505", # Unnecessary {branch} after return statement
"RET506", # Unnecessary {branch} after raise statement
"RET507", # Unnecessary {branch} after continue statement
"RET508", # Unnecessary {branch} after break statement
|
btw, asotille recently left sentry so we wont probably hear from him on this issue. |
|
|
|
Seem to be a conflict with the branch removing automatically added contentypes, will send a fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have made things!
I've tried to avoid as much as possible false positive on loosely typed cases.
cc @asottile-sentry , would be awesome if can try to cherry-pick a1f80ea to see if it fixes your issue.
Related issues
Fixes #2818