Skip to content

Update syndication Feed class #800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 30, 2021
Merged

Update syndication Feed class #800

merged 2 commits into from
Dec 30, 2021

Conversation

Crocmagnon
Copy link
Contributor

Followup of #798

Crocmagnon
Crocmagnon commented Dec 29, 2021
View reviewed changes
Crocmagnon
Crocmagnon commented Dec 29, 2021
View reviewed changes
Crocmagnon
Crocmagnon commented Dec 29, 2021
View reviewed changes
sobolevn
sobolevn reviewed Dec 29, 2021
View reviewed changes
@Crocmagnon
Copy link
Contributor Author

Thank you for your help!

sobolevn
sobolevn requested changes Dec 30, 2021
View reviewed changes
Copy link
Member

@sobolevn sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Can you please add a simple test case for it?
Because this looks quite complex, we don't want to break it in the future.

@Crocmagnon
Copy link
Contributor Author

Crocmagnon commented Dec 30, 2021 •
edited
Loading

Well, unfortunately the precise typing I was going with was not usable on a real subclass and I couldn't find a way to make it work.

Seems like mypy doesn't appreciate Unions of Callables as potential methods. I went with Any, as it at least lets people know that these exist even if the type doesn't give much information.

How should I test it?

sobolevn
sobolevn approved these changes Dec 30, 2021
View reviewed changes
Copy link
Member

@sobolevn sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any is fine as is! Thanks!

@sobolevn sobolevn merged commit 3b02222 into typeddjango:master Dec 30, 2021
@UnknownPlatypus UnknownPlatypus mentioned this pull request Oct 18, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sobolevn sobolevn sobolevn approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Crocmagnon @sobolevn