Case-insensitive string parsers #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is great, one minor nit. If you have time, follow up with a PR, but in the spirit of merge often, I'll merge this. |
johnynek
reviewed
Nov 6, 2020
| * this is an error if the string is empty | ||
| */ | ||
| def stringCI1(str: String): Parser1[Unit] = | ||
| if (str.length == 1) charIn(str.charAt(0).toLower, str.charAt(0).toUpper).void |
There was a problem hiding this comment.
nit, can we call charAt once and capture in a val? It makes it a bit easier to read.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some grammars, like SQL, unfortunately need case-insensitive token matching. This adds this functionality.