Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some ignoreCase methods, rename stringCI to ignoreCase #50

Merged
merged 1 commit into from
Nov 8, 2020

Conversation

johnynek
Copy link
Collaborator

@johnynek johnynek commented Nov 7, 2020

follow up to #46

What do you think @stephenjudkins ? I want to publish a new version, but the name just wasn't sitting well with me.

Can you review this and the other new methods I added?

There is one ambiguity: string can be converted to Iterable[Char] in scala, so I added ignoreCaseChar and ignoreCaseCharIn but to save space for the common case, I used ignoreCase to accept a string. A clearer, but more verbose approach would be to do ignoreCaseString, but I feel that's a bit long. That said, ignoring case isn't that common, so maybe that's okay. I don't know.

@stephenjudkins
Copy link
Contributor

👍 i think this all looks great. I picked stringCI simply because it was the name use in atto but I like these a bit better. I wouldn't quibble too much about ignoreCaseString vs ignoreCase, I think having string be the "default" thing is probably what 99% of parsers will be doing

@johnynek johnynek merged commit 7b07700 into main Nov 8, 2020
@johnynek johnynek deleted the oscar/rename_to_ignore_case branch November 8, 2020 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants