Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change MonadErrorOps#reject so it no longer runs effects twice #2810

Merged
merged 2 commits into from Apr 25, 2019

Conversation

@bplommer
Copy link
Contributor

commented Apr 25, 2019

Fixes #2809

@LukaJCB

This comment has been minimized.

Copy link
Member

commented Apr 25, 2019

Thanks for bringing this to our attention, this indeed sounds like a bug. Technically this is a breaking change, but I think we should merge this as a bug fix 👍

@kailuowang
Copy link
Member

left a comment

Thanks!

@kailuowang kailuowang merged commit 0d6aafc into typelevel:master Apr 25, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@kailuowang kailuowang added the bug label Apr 25, 2019

@kailuowang kailuowang modified the milestones: 2.0.0-M1, 2.0.0-RC1 Apr 25, 2019

@bplommer bplommer deleted the bplommer:reject-bugfix-pr branch Apr 25, 2019

rossabaker added a commit to rossabaker/cats that referenced this pull request May 26, 2019
Change MonadErrorOps#reject so it no longer runs effects twice (typel…
…evel#2810)

* Add regression test for MonadErrorOps bug

* Change MonadErrorOps#reject so it no longer re-runs the effect it is called on. Fixes typelevel#2809
rossabaker added a commit that referenced this pull request Jun 3, 2019
Backports for a cats-1.6.x patch (#2861)
* Change MonadErrorOps#reject so it no longer runs effects twice (#2810)

* Add regression test for MonadErrorOps bug

* Change MonadErrorOps#reject so it no longer re-runs the effect it is called on. Fixes #2809

* Fix Order.max and Oder.min description comments (#2842)

Changed description to better fit their implentation

* Make WrappedMutableMapBase extend Serializable (#2784)

We are running into Spark `Task not serializable` issues when a closure
that executes on a Spark executor node involves a `Map` that is created
via running `foldMap` on a `List`. This commit makes the
`WrappedMutableMap` hierarchy extend `Serializable` and chex that the
cerealization works (this test failed before extending `Serializable`).

* Optimize productR in Apply (#2728)

@kailuowang kailuowang modified the milestones: 2.0.0-RC1, 2.0.0-M2 Jun 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.