#2947 Added bifold to Bifoldable typeclass

[Twizty]

Implemented #2947

[Twizty]

java.lang.RuntimeException: Could not run jekyll, error: 1 is it a known issue or did I do something wrong?

[LukaJCB]

Hey @Twizty, what's the reason you closed this? I think it was a fine PR. Sorry no one responded to you, not sure what went wrong there, I restarted the Travis job to see if it was just a temporary error :)

[codecov-io]

Codecov Report

Merging #3088 into master will decrease coverage by 0.33%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #3088      +/-   ##
==========================================
- Coverage   93.57%   93.24%   -0.34%     
==========================================
  Files         371      375       +4     
  Lines        7097     7293     +196     
  Branches      185      196      +11     
==========================================
+ Hits         6641     6800     +159     
- Misses        456      493      +37

Flag	Coverage Δ
#scala_version_212	93.57% <100%> (ø)	⬆️
#scala_version_213	90.89% <100%> (?)

Impacted Files	Coverage Δ
core/src/main/scala/cats/Bifoldable.scala	91.66% <100%> (+0.75%)	⬆️
...e/src/main/scala-2.13+/cats/data/ZipLazyList.scala	77.77% <0%> (ø)
...src/main/scala-2.13+/cats/instances/lazyList.scala	100% <0%> (ø)
....13+/cats/kernel/instances/LazyListInstances.scala	100% <0%> (ø)
.../main/scala-2.13+/cats/data/NonEmptyLazyList.scala	62.5% <0%> (ø)
...in/scala/cats/data/AbstractNonEmptyInstances.scala	100% <0%> (+3.44%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d191a5...b173026. Read the comment docs.

[kailuowang]

i fixed your comment @LukaJCB , now pending build green

[LukaJCB]

Needs a scalafmt run

[travisbrown]

@kailuowang @LukaJCB I think that last merge got this out of sync, which makes review difficult, since there are a lot of extraneous changes in the diff—mind if I rebase to clean it up?

[LukaJCB]

Go for it @travisbrown

[travisbrown]

I think ideally I'd like to see a test here for something like Tuple2 but I'd be happy to see it merged as-is.