Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MiMa failing #478

Closed
armanbilge opened this issue Jan 18, 2022 · 11 comments · Fixed by #480
Closed

MiMa failing #478

armanbilge opened this issue Jan 18, 2022 · 11 comments · Fixed by #480

Comments

@armanbilge
Copy link
Member

Due to #477, sorry! I'm a little confused how it passed CI but not on main.

[error] (codegen / mimaPreviousClassfiles) sbt.librarymanagement.ResolveException: Error downloading org.typelevel:fs2-grpc-codegen_2.12:2.4.3
@ahjohannessen
Copy link
Collaborator

Can it be related to that change of Scala order?

@armanbilge
Copy link
Member Author

Oh, I see, you just tagged 2.4.3. Yikes, I thought these race conditions are fixed.

@ahjohannessen
Copy link
Collaborator

How do we go about fixing that?

@armanbilge
Copy link
Member Author

armanbilge commented Jan 18, 2022

There are two failures here:

  1. On the CI job started for the push, which is Push-and-tag still has a race condition sbt-typelevel#75. Annoying but fixable.
  2. On the CI job started for the tag, which I don't totally understand yet why it failed. Looking into it now.

The workaround is to wait for CI on main to finish before creating a tag/release. Edit: this workaround only applies to (1).

@armanbilge
Copy link
Member Author

Ok, I understood (2) and logged it in typelevel/sbt-typelevel#76.

I think I know how to fix both. Sorry for the trouble 😬

@ahjohannessen
Copy link
Collaborator

No problem @armanbilge - You are doing good work!

@ahjohannessen
Copy link
Collaborator

I deleted the 2.4.3 tag and release - as that never hit sonatype

@armanbilge
Copy link
Member Author

Thanks :) I have a fix incoming :)

@ahjohannessen
Copy link
Collaborator

ahjohannessen commented Jan 18, 2022

@armanbilge Now CI is green for main, is it safe to tag a version now?

@armanbilge
Copy link
Member Author

Unfortunately no, it is still affected by typelevel/sbt-typelevel#76 I believe. I'm about to push a fix, we'll have you publishing shortly :)

@ahjohannessen
Copy link
Collaborator

ok 👍

armanbilge added a commit to armanbilge/fs2-grpc that referenced this issue Jan 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants