Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to sbt-typelevel #477

Merged
merged 4 commits into from
Jan 18, 2022

Conversation

armanbilge
Copy link
Member

No description provided.

@ahjohannessen
Copy link
Collaborator

@armanbilge Please see https://github.com/armanbilge/fs2-grpc/pull/1/files :) - This is great, btw! 👍

@armanbilge
Copy link
Member Author

:)

FYI it's dangerous to publish artifacts compiled with JDK 17. Even with those compatibility flags (which I believe scalac adds by default anyway) you can generate bytecode that doesn't link on older JDKs. Fs2 has to be careful about this all the time when using the Buffer APIs.

@ahjohannessen
Copy link
Collaborator

FYI it's dangerous to publish artifacts compiled with JDK 17. Even with those compatibility flags (which I believe scalac adds by default anyway) you can generate bytecode that doesn't link on older JDKs. Fs2 has to be careful about this all the time when using the Buffer APIs.

I'll add JDK8 back

@ahjohannessen
Copy link
Collaborator

@armanbilge I have updated my PR, WDYT? Changed the order of Scala versions in order to have Scala3 on temurin17/8 for CI - So if you adjust your PR with that, I'll merge.

ci: make scala 3 test with both jvm17 & jvm8
@ahjohannessen ahjohannessen merged commit f4eba10 into typelevel:main Jan 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants