Skip to content

Add initial version of "Enhancements to referring to actions by commit hash" #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jul 6, 2025
Merged

Add initial version of "Enhancements to referring to actions by commit hash" #1

merged 8 commits into from
Jul 6, 2025

Conversation

krzema12
Copy link
Member

@krzema12 krzema12 commented Apr 27, 2025 •
edited
Loading

@krzema12 krzema12 mentioned this pull request Apr 27, 2025
Open
@krzema12 krzema12 requested review from Vampire and LeoColman May 22, 2025 21:10
Vampire
Vampire suggested changes May 23, 2025
View reviewed changes
Copy link

@Vampire Vampire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As it all-in-all is the approach I suggested, LGTM.
Just some nits. :-)

krzema12 and others added 2 commits June 22, 2025 21:08
@krzema12 krzema12 requested a review from Vampire June 22, 2025 19:17
@krzema12
Copy link
Member Author

@Vampire addressed all your comments, thanks - good catches! Mind taking one last look before we start implementing?

@krzema12 krzema12 merged commit fe87b42 into main Jul 6, 2025
@krzema12 krzema12 deleted the enhancements-commit-hash branch July 6, 2025 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LeoColman LeoColman Awaiting requested review from LeoColman

@Vampire Vampire Awaiting requested review from Vampire

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@krzema12 @Vampire