Enable cross publishing for Scala 2.12 #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huntc
force-pushed
the
cross-build-2.12
branch
from
45b16e1
to
b78e892
Compare
fsat
approved these changes
Dec 7, 2016
|
I think it is easier to declare it across the board and then tweak it as necessary - it should be the exception rather than the rule for a sub project to have special requirements. |
|
The CI failed because of JDK 7 being used. Unfortunately JDK 7 is no longer suitable in order to run our tests ,even though the resultant artifacts are targeted at JDK 6. The reason for this is that we've had to start using the Akka 2.4 libraries so that we can cross compile 2.12 i.e. there's a trade. I will enable the JDK 7 based testing only for the Akka 2.3 and Play 2.3 libraries now. |
huntc
force-pushed
the
cross-build-2.12
branch
from
b78e892
to
4883bab
Compare
Specifically excludes projects in the cross build that do not, or indeed will not support Scala 2.12.
huntc
force-pushed
the
cross-build-2.12
branch
from
4883bab
to
c4fac40
Compare
|
Had to remove the JDK 7 runtime entirely - just won't work for us given the necessity of the Akka 2.4 tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifically excludes projects in the cross build that do not, or indeed will not support Scala 2.12.
I'm unsure if this is totally correct, but I can
+ testfrom the root project and it will compile/test correct for both 2.11 and 2.12. We won't know if the publish/release actually works until we try it, and this PR needs to be merged before that can happen.sbt-dogeis used to solve a cross building problem within sbt.