Skip to content

Filled in missing 100% unit test coverage in reportConversionResults #123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 28, 2019
Merged

Filled in missing 100% unit test coverage in reportConversionResults #123

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 28 additions & 1 deletion src/reporting/reportConversionResults.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,34 @@ import { ConversionError } from "../errors/conversionError";
import { ConfigurationError } from "../errors/configurationError";

describe("reportConversionResults", () => {
it("logs a successful conversion when there is one converted rule", () => {
it("logs a successful conversion without notices when there is one converted rule without notices", () => {
// Arrange
const conversionResults = createEmptyConversionResults({
converted: new Map<string, ESLintRuleOptions>([
[
"tslint-rule-one",
{
ruleArguments: ["a", "b"],
ruleName: "tslint-rule-one",
ruleSeverity: "error",
},
],
]),
});

const logger = createStubLogger();

// Act
reportConversionResults({ logger }, conversionResults);

// Assert
expectEqualWrites(
logger.stdout.write,
`✨ 1 rule replaced with its ESLint equivalent. ✨${EOL}`,
);
});

it("logs a successful conversion with notices when there is one converted rule with notices", () => {
// Arrange
const conversionResults = createEmptyConversionResults({
converted: new Map<string, ESLintRuleOptions>([
Expand Down