chore: Fix @typescript-eslint/sort-type-constituents errors
#1718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yeah :/ this repo isn't converted to http://github.com/JoshuaKGoldberg/template-typescript-node-package yet. I'm hoping to finish up all the templating I'd wanted in that package this month, then migrate all my repos over. |
JoshuaKGoldberg
approved these changes
Aug 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
status: accepting prsOverview
When working on #1717 and #1716, I noticed that ESLint snagged on some unrelated code in CI (but not locally). This fixes the errors that show up in CI.
The environment difference seems to be related to the difference in package resolution. Locally,
rm -rf node_modules && pnpm i && pnpm run eslintdoes not show the ESLint errors. However,rm -rf node_modules && npm ci && pnpm run eslintdoes.