fix(prefer-arrow-functions): Allow allowStandaloneDeclarations by default
#1719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hyperupcall
changed the title
allowStandaloneDeclarations by d…allowStandaloneDeclarations by default
JoshuaKGoldberg
requested changes
Aug 3, 2023
| @@ -17,6 +17,11 @@ export const convertOnlyArrowFunctions: RuleConverter = (tslintRule) => { | |||
| rules: [ | |||
| { | |||
| ...(notices.length !== 0 && { notices }), | |||
| ruleArguments: [ | |||
| { | |||
| allowStandaloneDeclarations: true, | |||
There was a problem hiding this comment.
I poked through the issue (what a throwback!) and TristonJ/eslint-plugin-prefer-arrow#16 as you'd linked - thanks for the info. It look to me like allowStandaloneDeclarations should only be output if "allow-declarations" is in the original rule. And we can get rid of the "ESLint does not support allowing standalone function declarations." notice.
JoshuaKGoldberg
added
the
status: waiting for author
hyperupcall
force-pushed
the
hyperupcall-fix-default
branch
from
4d72fb0 to
66b7640
Compare
|
You're right - the property is opt-in - that's my mistake. The new logic fixes the conversion result |
JoshuaKGoldberg
removed
the
status: waiting for author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
status: accepting prsOverview
Change the default of
prefer-arrow/prefer-arrow-functionssoallowStandaloneDeclarationsis enabled.